Patch Set 1:
Ping?
--
To view, visit https://gerrit.osmocom.org/6197
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I03d0d3d32a8d572ad573d03c603e14cdc27a3f7b
Gerrit-PatchSet: 1
Gerrit-Project: libosmocore
Gerrit-Branch: master
Patch Set 1:
(1 comment)
https://gerrit.osmocom.org/#/c/6197/1/include/osmocom/gsm/gsup.h
File include/osmocom/gsm/gsup.h:
Line 118: #define OSMO_GSUP_COPY_IMSI(msg, _imsi) osmo_strlcpy((msg)->imsi,
_imsi, GSM23003_IMSI_MAX_DIGITS + 2)
why not a sizeof((msg)->imsi)? And why not actually a
Review at https://gerrit.osmocom.org/6197
GSUP: add helper wrapper for setting IMSI
Related: OS#2864
Change-Id: I03d0d3d32a8d572ad573d03c603e14cdc27a3f7b
---
M include/osmocom/gsm/gsup.h
1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/libosmocore
