[MERGED] libosmocore[master]: doxygen: gsm: do not exclude include/gsm/protocol/*

2017-06-25 Thread Neels Hofmeyr
Neels Hofmeyr has submitted this change and it was merged. Change subject: doxygen: gsm: do not exclude include/gsm/protocol/* .. doxygen: gsm: do not exclude include/gsm/protocol/* Clear out the EXCLUDE tag to not exclude anyt

libosmocore[master]: doxygen: gsm: do not exclude include/gsm/protocol/*

2017-06-25 Thread Neels Hofmeyr
Patch Set 5: Code-Review+2 tweaked commit log... -- To view, visit https://gerrit.osmocom.org/2979 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib569a46f00866bdaa4017f803d85f625ae011316 Gerrit-PatchSet: 5 Gerrit-Project: libosmocore Ge

[PATCH] libosmocore[master]: doxygen: gsm: do not exclude include/gsm/protocol/*

2017-06-25 Thread Neels Hofmeyr
Hello Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/2979 to look at the new patch set (#5). doxygen: gsm: do not exclude include/gsm/protocol/* Clear out the EXCLUDE tag to not exclude anything. Tried to add API doc to gsm/prot

libosmocore[master]: doxygen: gsm: do not exclude include/gsm/protocol/*

2017-06-23 Thread Harald Welte
Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/2979 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib569a46f00866bdaa4017f803d85f625ae011316 Gerrit-PatchSet: 3 Gerrit-Project: libosmocore Gerrit-Branch: master Ger

libosmocore[master]: doxygen: gsm: do not exclude include/gsm/protocol/*

2017-06-22 Thread Neels Hofmeyr
Patch Set 2: If I were a user of the HTML API doc, I would expect all data types to be listed and linked... I don't have a strong opinion really since I usually read the source code instead. -- To view, visit https://gerrit.osmocom.org/2979 To unsubscribe, visit https://gerrit.osmocom.org/set

libosmocore[master]: doxygen: gsm: do not exclude include/gsm/protocol/*

2017-06-21 Thread Harald Welte
Patch Set 2: the reason to exclude it is that this directory contains definitions taken 1:1 from related GSM specifications and thus not some APIs or data types that we have come up with. I think it's best to not replicate what's written in 3GPP specs. However, we can of course include it me

[PATCH] libosmocore[master]: doxygen: gsm: do not exclude include/gsm/protocol/*

2017-06-19 Thread Neels Hofmeyr
Review at https://gerrit.osmocom.org/2979 doxygen: gsm: do not exclude include/gsm/protocol/* Clear out the EXCLUDE tag to not exclude anything. Tried to add API doc to gsm/protocol/gsm_08_08.h and after a long time found out why they are not appearing in the API doc. It's not clear to me why