libosmocore[master]: fsm_test.c: fix unreachable check

2017-05-15 Thread Holger Freyther
Patch Set 2: Ouch. Yesterday night I read "unreliable" instead of unreachable. :) -- To view, visit https://gerrit.osmocom.org/2591 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic3d5da00f7ece6dbcd4c999187a5748c9331e60f Gerrit-PatchSet:

libosmocore[master]: fsm_test.c: fix unreachable check

2017-05-15 Thread Vadim Yanitskiy
Patch Set 2: > This dead code analysis is done by the static > checker you were using? Yeah, I used cppcheck. > I don't think the code will get more reliable through it? What do you mean by "more reliable"? With OSMO_ASSERT? -- To view, visit https://gerrit.osmocom.org/2591 To unsubscribe,

libosmocore[master]: fsm_test.c: fix unreachable check

2017-05-15 Thread Holger Freyther
Patch Set 2: This dead code analysis is done by the static checker you were using? I don't think the code will get more reliable through it? -- To view, visit https://gerrit.osmocom.org/2591 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id

[MERGED] libosmocore[master]: fsm_test.c: fix unreachable check

2017-05-15 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: fsm_test.c: fix unreachable check .. fsm_test.c: fix unreachable check Change-Id: Ic3d5da00f7ece6dbcd4c999187a5748c9331e60f --- M tests/fsm/fsm_test.c 1

libosmocore[master]: fsm_test.c: fix unreachable check

2017-05-15 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/2591 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic3d5da00f7ece6dbcd4c999187a5748c9331e60f Gerrit-PatchSet: 1 Gerrit-Project: libosmocore Gerrit-Branch: master Ger

libosmocore[master]: fsm_test.c: fix unreachable check

2017-05-15 Thread Max
Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/2591 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic3d5da00f7ece6dbcd4c999187a5748c9331e60f Gerrit-PatchSet: 1 Gerrit-Project: libosmocore Gerrit-Branch: master Ger

[PATCH] libosmocore[master]: fsm_test.c: fix unreachable check

2017-05-14 Thread Vadim Yanitskiy
Review at https://gerrit.osmocom.org/2591 fsm_test.c: fix unreachable check Change-Id: Ic3d5da00f7ece6dbcd4c999187a5748c9331e60f --- M tests/fsm/fsm_test.c 1 file changed, 3 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/91/2591/1 diff --git a