Harald Welte has submitted this change and it was merged.
Change subject: gsm0808: Add utils for Speech Codec List and Speech Codec
..
gsm0808: Add utils for Speech Codec List and Speech Codec
The planned support for true A ove
Patch Set 4: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/2177
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0e1e2edf47adaa45b22d4b0bcae3640dba7ca200
Gerrit-PatchSet: 4
Gerrit-Project: libosmocore
Gerrit-Branch: master
Ger
Hello Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/2177
to look at the new patch set (#4).
gsm0808: Add utils for Speech Codec List and Speech Codec
The planned support for true A over IP requires the encoding and
decoding of a
Patch Set 3: Code-Review+1
(3 comments)
with const, it would be perfect :)
https://gerrit.osmocom.org/#/c/2177/3/include/osmocom/gsm/gsm0808_utils.h
File include/osmocom/gsm/gsm0808_utils.h:
Line 28:struct sockaddr_storage *ss);
const
Line 36:
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/2177
to look at the new patch set (#3).
gsm0808: Add utils for Speech Codec List and Speech Codec
The planned support for true A over IP requires the encoding and
decoding of a so called "Sp
Patch Set 2:
(1 comment)
https://gerrit.osmocom.org/#/c/2177/2/src/gsm/gsm0808_utils.c
File src/gsm/gsm0808_utils.c:
Line 151: struct msgb *gsm0808_enc_speech_codec(struct gsm0808_speech_codec *sc)
I think I don't really understand the idea behind those functions. When we
encode an entire mes
Review at https://gerrit.osmocom.org/2177
gsm0808: Add utils for Speech Codec List and Speech Codec
The planned support for true A over IP requires the encoding and
decoding of a so called "Speech Codec Element" element.
This commt adds parsing functionality and tests for the element
mentioned
