libosmocore[master]: utils: add function gsm_print_fn2gsmtime()

2017-06-26 Thread Max
Patch Set 3: Please change commit message to reflect function name properly - or use some text instead of function name. -- To view, visit https://gerrit.osmocom.org/3048 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8015d2ded3940b01b

[PATCH] libosmocore[master]: utils: add function gsm_print_fn2gsmtime()

2017-06-26 Thread dexter
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/3048 to look at the new patch set (#3). utils: add function gsm_print_fn2gsmtime() Convert a given frame number into a printable string that displays the sub components of the frame number.

[PATCH] libosmocore[master]: utils: add function gsm_print_fn2gsmtime()

2017-06-26 Thread dexter
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/3048 to look at the new patch set (#2). utils: add function gsm_print_fn2gsmtime() Convert a given frame number into a printable string that displays the sub components of the frame number.

libosmocore[master]: utils: add function gsm_print_fn2gsmtime()

2017-06-26 Thread Max
Patch Set 1: The name is kinda confusing to me: smth like gsm_fn_as_gsmtime_str() would be better. Also, depending on the way you plan to use it might make sense to "print" FN as well. -- To view, visit https://gerrit.osmocom.org/3048 To unsubscribe, visit https://gerrit.osmocom.org/settings

[PATCH] libosmocore[master]: utils: add function gsm_print_fn2gsmtime()

2017-06-26 Thread dexter
Review at https://gerrit.osmocom.org/3048 utils: add function gsm_print_fn2gsmtime() Convert a given frame number into a printable string that displays the sub components of the frame number. Change-Id: I8015d2ded3940b01b35df7b72fc35c70c25e9926 --- M include/osmocom/gsm/gsm_utils.h M src/gsm/g