openbsc[master]: Get basic BTS attributes

2017-05-17 Thread Harald Welte
Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/2544 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I589be51daca0cb9e1f3473b93e910e46b06e23ae Gerrit-PatchSet: 3 Gerrit-Project: openbsc Gerrit-Branch: master Gerrit-

[MERGED] openbsc[master]: Get basic BTS attributes

2017-05-17 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: Get basic BTS attributes .. Get basic BTS attributes Request BTS attributes via OML on connection and parse the response: request/parse incoming response

[PATCH] openbsc[master]: Get basic BTS attributes

2017-05-15 Thread Max
Hello Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/2544 to look at the new patch set (#3). Get basic BTS attributes Request BTS attributes via OML on connection and parse the response: request/parse incoming response as sw-conf

openbsc[master]: Get basic BTS attributes

2017-05-14 Thread Harald Welte
Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/2544 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I589be51daca0cb9e1f3473b93e910e46b06e23ae Gerrit-PatchSet: 2 Gerrit-Project: openbsc Gerrit-Branch: master Gerrit-

openbsc[master]: Get basic BTS attributes

2017-05-11 Thread Max
Patch Set 2: Well, yes and no. We have to pass several key-value pairs of arbitrary length. Each can be represented as TLV but all of them should be transferred as a collection of some sort. So we have to either write own one serializer/deserializer for such a collection or use existing one. I

openbsc[master]: Get basic BTS attributes

2017-05-10 Thread Harald Welte
Patch Set 2: > > Is the SW config contents not again "juts" some kind of TLV > structure? > > Unfortunately not. Neither Get Attribute Response Info nor > SW-Config are TLV-type structures. I've added clarifying comments > and references to the spec. I think those are too specific to > att

openbsc[master]: Get basic BTS attributes

2017-05-10 Thread Max
Patch Set 2: > Is the SW config contents not again "juts" some kind of TLV structure? Unfortunately not. Neither Get Attribute Response Info nor SW-Config are TLV-type structures. I've added clarifying comments and references to the spec. I think those are too specific to attempt to accommodat

[PATCH] openbsc[master]: Get basic BTS attributes

2017-05-10 Thread Max
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/2544 to look at the new patch set (#2). Get basic BTS attributes Request BTS attributes via OML on connection and parse the response: request/parse incoming response as sw-config. Note: onl

openbsc[master]: Get basic BTS attributes

2017-05-09 Thread Harald Welte
Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/2544/1/openbsc/src/libbsc/abis_nm.c File openbsc/src/libbsc/abis_nm.c: Line 488: this seems overly complex and ave lots of manual, non-obvious pointer arithmetics. Why do we need this? Wh to we start to have iterator style parsing with

[PATCH] openbsc[master]: Get basic BTS attributes

2017-05-09 Thread Max
Review at https://gerrit.osmocom.org/2544 Get basic BTS attributes Request BTS attributes via OML on connection and parse the response: * make attribute list const * expand gsm_bts-features * add sub_model to gsm_bts * request/parse incoming response as sw-config Note: only basic BTS-wide KV a