[MERGED] openbsc[master]: nat: Fix initial buffer size parameter for getline

2017-04-24 Thread Pau Espin Pedrol
Pau Espin Pedrol has submitted this change and it was merged. Change subject: nat: Fix initial buffer size parameter for getline .. nat: Fix initial buffer size parameter for getline According to man, lineptr must be set to nul

openbsc[master]: nat: Fix initial buffer size parameter for getline

2017-04-12 Thread Pau Espin Pedrol
Patch Set 1: I was reading the code and I was not understanding why that value was being passed to getline() so I went have a look at man to see if I was missing something. -- To view, visit https://gerrit.osmocom.org/2287 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-Mess

openbsc[master]: nat: Fix initial buffer size parameter for getline

2017-04-11 Thread Holger Freyther
Patch Set 1: Code-Review+2 How did you see this? Code review? Compiler warning? The BSD manpage is not that clear here. As linep is NULL a new buffer will be allocated which leads to updating these values. But there is no point to insist on 2342 as initial value. -- To view, visit https://ge

[PATCH] openbsc[master]: nat: Fix initial buffer size parameter for getline

2017-04-10 Thread Pau Espin Pedrol
Review at https://gerrit.osmocom.org/2287 nat: Fix initial buffer size parameter for getline According to man, lineptr must be set to null AND n to 0. Change-Id: I36683884106b97ef697264716de13813c00da9bc --- M openbsc/src/osmo-bsc_nat/bsc_nat_rewrite_trie.c 1 file changed, 1 insertion(+), 1 de