Patch Set 8: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/3127
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia8739b6e329ab02c0064270d02ad1d6ee245520d
Gerrit-PatchSet: 8
Gerrit-Project: openbsc
Gerrit-Branch: master
Gerrit-
Harald Welte has submitted this change and it was merged.
Change subject: transaction: reject calls from unidentified subscribers
..
transaction: reject calls from unidentified subscribers
A valid subscriber is indespensible wh
Hello Max, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/3127
to look at the new patch set (#8).
transaction: reject calls from unidentified subscribers
A valid subscriber is indespensible when allocating a new
transaction. Return NULL if no
Hello Max, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/3127
to look at the new patch set (#6).
transaction: reject calls from unidentified subscribers
A valid subscriber is indespensible when allocating a new
transaction. Return NULL if no
Hello Max, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/3127
to look at the new patch set (#5).
transaction: reject calls from unidentified subscribers
A valid subscriber is indespensible when allocating a new
transaction. Return NULL if no
Patch Set 4:
(2 comments)
> Who called it with a NULL subscr? Do you think it is approriate to
> call this function with a NULL subscriber?
>
> If nonnull attribute wouldn't influence the optimizer I would say
> let's mark the parameter as non NULL.
I am not entirely sure, subscr==NULL is
Patch Set 4:
Who called it with a NULL subscr? Do you think it is approriate to call this
function with a NULL subscriber?
If nonnull attribute wouldn't influence the optimizer I would say let's mark
the parameter as non NULL.
--
To view, visit https://gerrit.osmocom.org/3127
To unsubscribe,
Patch Set 4:
(1 comment)
https://gerrit.osmocom.org/#/c/3127/4/openbsc/src/libmsc/transaction.c
File openbsc/src/libmsc/transaction.c:
Line 75:DEBUGP(DCC,
I think this should be INFO or probably even NOTICE level, as it is not
something that relates to debugging the software, b
Patch Set 4: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/3127
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia8739b6e329ab02c0064270d02ad1d6ee245520d
Gerrit-PatchSet: 4
Gerrit-Project: openbsc
Gerrit-Branch: master
Gerrit-
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/3127
to look at the new patch set (#4).
transaction: reject calls from unidentified subscribers
A valid subscriber is indespensible when allocating a new
transaction. Return NULL if no subsc
Patch Set 3:
(1 comment)
https://gerrit.osmocom.org/#/c/3127/3/openbsc/src/libmsc/transaction.c
File openbsc/src/libmsc/transaction.c:
Line 74:if (subscr == NULL)
Is this normal? Should we log smth or caller takes care of it?
--
To view, visit https://gerrit.osmocom.org/3127
To unsub
Review at https://gerrit.osmocom.org/3127
transaction: reject calls from unidentified subscribers
A valid subscriber is indespensible when allocating a new
transaction. Return NULL if no subscriber is supplied. This
will cause unidentified subscribers to be rejected.
Change-Id: Ia8739b6e329ab0
12 matches
Mail list logo
