Harald Welte has posted comments on this change. (
https://gerrit.osmocom.org/6203 )
Change subject: abis-rsl: Send imm.ass messages via PCH
..
Patch Set 3:
I think we should have a test case in ttcn3 and then we can sa felt m
dexter has posted comments on this change. ( https://gerrit.osmocom.org/6203 )
Change subject: abis-rsl: Send imm.ass messages via PCH
..
Patch Set 3:
> (1 comment)
>
> @dexter should we review this together before ask somebo
Patch Set 3: Code-Review-1
(1 comment)
@dexter should we review this together before ask somebody else?
https://gerrit.osmocom.org/#/c/6203/3/src/libbsc/abis_rsl.c
File src/libbsc/abis_rsl.c:
PS3, Line 1130: msg, 0x0e
use a define from libosmocore
--
To view, visit https://gerrit.osmocom.or
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/6203
to look at the new patch set (#3).
abis-rsl: Send imm.ass messages via PCH
It is possible to send immidiate assign messages through the
paging channel. This commit adds the required fun
Patch Set 2:
i've just copied. this is of course not ready for submit.
I would split off the abis-rsl message from the pcu socket modifications
--
To view, visit https://gerrit.osmocom.org/6203
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/6203
to look at the new patch set (#2).
abis-rsl: Send imm.ass messages via PCH
It is possible to send immidiate assign messages through the
paging channel. This commit adds the required fun
Patch Set 1:
I think this patch also suffered rebase issues.
--
To view, visit https://gerrit.osmocom.org/6203
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0a899d9c866ed09dc301694dbbcad304b1ed49e5
Gerrit-PatchSet: 1
Gerrit-Project: os
Patch Set 1:
It's been too long since looking at this: but isn't sending packet related
assignments (for DL tbf) what we do all the time even with existing bts-located
pcu? If so, why does the PCU socket interface need to change? Please
clarify/explain
--
To view, visit https://gerrit.osmoco
Patch Set 1:
let's clean it up and get merged.
--
To view, visit https://gerrit.osmocom.org/6203
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0a899d9c866ed09dc301694dbbcad304b1ed49e5
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bsc
Gerrit-
Patch Set 1: Code-Review-1
PCU protocol needs to be increased.
--
To view, visit https://gerrit.osmocom.org/6203
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0a899d9c866ed09dc301694dbbcad304b1ed49e5
Gerrit-PatchSet: 1
Gerrit-Project:
Patch Set 1:
(1 comment)
https://gerrit.osmocom.org/#/c/6203/1/src/libbsc/abis_rsl.c
File src/libbsc/abis_rsl.c:
Line 1129: msgb_put_u8(msg, 0x0e);
create a define for this field
--
To view, visit https://gerrit.osmocom.org/6203
To unsubscribe, visit https://gerrit.osmocom.org/settings
Patch Set 1:
https://gerrit.osmocom.org/#/c/2066/
missing TODO:
openbsc/include/openbsc/pcuif_proto.h
Line 64:
this changes the layout of the PCU socket interface protocol, and hence should
be accompaned by a version increment in the pcu interface protocol to ensure
both sides of the socket h
Review at https://gerrit.osmocom.org/6203
abis-rsl: Send imm.ass messages via PCH
It is possible to send immidiate assign messages through the
paging channel. This commit adds the required functionality to
the pcu socket interface and to the abis_rsl api
Change-Id: I0a899d9c866ed09dc301694dbbc
13 matches
Mail list logo
