Harald Welte has submitted this change and it was merged.
Change subject: vty: 'show bts': list the TRXs' ARFCNs
..
vty: 'show bts': list the TRXs' ARFCNs
Change-Id: I56ee2edc7473dc5e9f3c3463194369024cd64995
---
M src/libbsc/bs
Patch Set 4: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6478
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I56ee2edc7473dc5e9f3c3463194369024cd64995
Gerrit-PatchSet: 4
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/6478
to look at the new patch set (#4).
vty: 'show bts': list the TRXs' ARFCNs
Change-Id: I56ee2edc7473dc5e9f3c3463194369024cd64995
---
M src/libbsc/bsc_vty.c
1 file changed, 33 insertions(+
Patch Set 1:
(1 comment)
https://gerrit.osmocom.org/#/c/6478/1/src/libbsc/bsc_vty.c
File src/libbsc/bsc_vty.c:
Line 285: vty_out(vty, " ARFCNs:");
> actually the hopping is in the trx->ts, so I need to iterate all the ts fir
yes, or be cheap and simply state "ARFCNs: Hopping" for now. I
Patch Set 3:
put it back to what it was before, showing hopping TS needs more reflection and
a considerably larger patch...
So, in the presence of hopping TS, the TRX's configured ARFCN has absolutely no
meaning? Otherwise we could merge this as-is and follow up later?
--
To view, visit http
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/6478
to look at the new patch set (#3).
vty: 'show bts': list the TRXs' ARFCNs
Change-Id: I56ee2edc7473dc5e9f3c3463194369024cd64995
---
M src/libbsc/bsc_vty.c
1 file changed, 8 insertions(+)
Patch Set 1:
(1 comment)
https://gerrit.osmocom.org/#/c/6478/1/src/libbsc/bsc_vty.c
File src/libbsc/bsc_vty.c:
Line 285: vty_out(vty, " ARFCNs:");
> well, I'll believe you right away because this is the first time I've heard
actually the hopping is in the trx->ts, so I need to iterate al
Patch Set 2:
argh, it helps to actually compile before submitting m(
--
To view, visit https://gerrit.osmocom.org/6478
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I56ee2edc7473dc5e9f3c3463194369024cd64995
Gerrit-PatchSet: 2
Gerrit-Pro
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/6478
to look at the new patch set (#2).
vty: 'show bts': list the TRXs' ARFCNs / MAIO+HSN
Change-Id: I56ee2edc7473dc5e9f3c3463194369024cd64995
---
M src/libbsc/bsc_vty.c
1 file changed, 12 i
Patch Set 1:
(1 comment)
https://gerrit.osmocom.org/#/c/6478/1/src/libbsc/bsc_vty.c
File src/libbsc/bsc_vty.c:
Line 285: vty_out(vty, " ARFCNs:");
> looks like this would only work for non-hopping TRXs. I guess we should ha
well, I'll believe you right away because this is the first tim
Patch Set 1:
(1 comment)
https://gerrit.osmocom.org/#/c/6478/1/src/libbsc/bsc_vty.c
File src/libbsc/bsc_vty.c:
Line 285: vty_out(vty, " ARFCNs:");
looks like this would only work for non-hopping TRXs. I guess we should have
some if (!trx->hopping.enabled) around printing trx->arfcn, an
Review at https://gerrit.osmocom.org/6478
vty: 'show bts': list the TRXs' ARFCNs
Change-Id: I56ee2edc7473dc5e9f3c3463194369024cd64995
---
M src/libbsc/bsc_vty.c
1 file changed, 8 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/78/6478/1
diff --gi
12 matches
Mail list logo
