Patch Set 4: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/2541
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4c5d0e2d9857160f905e743517e744f1a06368af
Gerrit-PatchSet: 4
Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Pau Espin Pedrol has submitted this change and it was merged.
Change subject: Log network activity using tcpdump for nitb interface
..
Log network activity using tcpdump for nitb interface
Change-Id: I4c5d0e2d9857160f905e743517
Hello Neels Hofmeyr, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/2541
to look at the new patch set (#4).
Log network activity using tcpdump for nitb interface
Change-Id: I4c5d0e2d9857160f905e743517e744f1a06368af
---
M src/osmo_gsm_tester/os
Patch Set 3: Code-Review+2
(1 comment)
https://gerrit.osmocom.org/#/c/2541/3/src/osmo_gsm_tester/util.py
File src/osmo_gsm_tester/util.py:
Line 46: if 'inet' in line and ' ' + ip + '/' in line:
(indent too deep)
--
To view, visit https://gerrit.osmocom.org/2541
To unsubsc
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/2541
to look at the new patch set (#3).
Log network activity using tcpdump for nitb interface
Change-Id: I4c5d0e2d9857160f905e743517e744f1a06368af
---
M src/osmo_gsm_tester/osmo_nitb.py
A sr
Patch Set 2:
(9 comments)
https://gerrit.osmocom.org/#/c/2541/2/src/osmo_gsm_tester/netlogger.py
File src/osmo_gsm_tester/netlogger.py:
Line 27: class NetLogger(log.Origin):
> don't really like the name, sounds like the gsm tester would write its own
Fine with change it to PcapRecorder
Line
Patch Set 2:
(9 comments)
https://gerrit.osmocom.org/#/c/2541/2/src/osmo_gsm_tester/netlogger.py
File src/osmo_gsm_tester/netlogger.py:
Line 27: class NetLogger(log.Origin):
don't really like the name, sounds like the gsm tester would write its own log
files to a remote host or something -- ma
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/2541
to look at the new patch set (#2).
Log network activity using tcpdump for nitb interface
Change-Id: I4c5d0e2d9857160f905e743517e744f1a06368af
---
A src/osmo_gsm_tester/netlogger.py
M sr
Review at https://gerrit.osmocom.org/2541
Log network activity using tcpdump for nitb interface
Change-Id: I4c5d0e2d9857160f905e743517e744f1a06368af
---
A src/osmo_gsm_tester/netlogger.py
M src/osmo_gsm_tester/osmo_nitb.py
M src/osmo_gsm_tester/util.py
3 files changed, 87 insertions(+), 2 delet
