Max has abandoned this change. ( https://gerrit.osmocom.org/6296 )
Change subject: Fix VLR test macro
..
Abandoned
--
To view, visit https://gerrit.osmocom.org/6296
To unsubscribe, or for help writing mail filters, visit
Pau Espin Pedrol has posted comments on this change. (
https://gerrit.osmocom.org/6296 )
Change subject: Fix VLR test macro
..
Patch Set 7:
If there's a clear required purpose for this please explain, otherwise we can
Harald Welte has posted comments on this change. (
https://gerrit.osmocom.org/6296 )
Change subject: Fix VLR test macro
..
Patch Set 7:
are the tests ever likely going to have more than one "conn" they want to match
on? If
Max has posted comments on this change. ( https://gerrit.osmocom.org/6296 )
Change subject: Fix VLR test macro
..
Set Ready For Review
--
To view, visit https://gerrit.osmocom.org/6296
To unsubscribe, or for help writing mail
Patch Set 6: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6296
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I36ae1f9bb395921dc2c5a39e35fbb8040ba47213
Gerrit-PatchSet: 6
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Hello daniel, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/6296
to look at the new patch set (#6).
Fix VLR test macro
Previously EXPECT_ACCEPTED used parameter which wasn't explicitly passed
to it. This is potential source of bugs and makes
Hello daniel, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/6296
to look at the new patch set (#5).
Fix VLR test macro
Previously EXPECT_ACCEPTED used parameter which wasn't explicitly passed
to it. This is potential source of bugs and makes
Patch Set 1:
(1 comment)
This one is fixed, I'll send update regarding other comments later on.
https://gerrit.osmocom.org/#/c/6296/1/tests/msc_vlr/msc_vlr_test_rest.c
File tests/msc_vlr/msc_vlr_test_rest.c:
Line 26: void test_early_stage(const char *imsi)
> This doesn't seem to belong here
Hello daniel, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/6296
to look at the new patch set (#4).
Fix VLR test macro
Previously EXPECT_ACCEPTED used parameter which wasn't explicitly passed
to it. This is potential source of bugs and makes
Patch Set 3: Code-Review-1
(3 comments)
I'd be in favor of keeping the macro, but adding another parameter to it.
https://gerrit.osmocom.org/#/c/6296/1/tests/msc_vlr/msc_vlr_test_rest.c
File tests/msc_vlr/msc_vlr_test_rest.c:
Line 26: void test_early_stage(const char *imsi)
This doesn't seem
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/6296
to look at the new patch set (#3).
Fix VLR test macro
Previously EXPECT_ACCEPTED used parameter which wasn't explicitly passed
to it. This is potential source of bugs and makes code
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/6296
to look at the new patch set (#2).
Fix VLR test macro
Previously EXPECT_ACCEPTED used parameter which wasn't explicitly passed
to it. This is potential source of bugs and makes code
12 matches
Mail list logo
