Neels Hofmeyr has abandoned this change.
Change subject: db: wrap dbi querying to log actual SQL on debug and error
..
Abandoned
I don't want to spend time on this, maybe I'll come back to it when the next
SQL error happens
-
Patch Set 1:
(1 comment)
https://gerrit.osmocom.org/#/c/5205/1/src/libmsc/db.c
File src/libmsc/db.c:
Line 197: dbi_result queryf(dbi_conn conn, const char *format, ...)
> That's just SQL injection waiting to happen. Too bad libdbi does not suppor
Our invocation of libdbi has always worked like
Patch Set 1: Code-Review+1
(1 comment)
https://gerrit.osmocom.org/#/c/5205/1/src/libmsc/db.c
File src/libmsc/db.c:
Line 197: dbi_result queryf(dbi_conn conn, const char *format, ...)
That's just SQL injection waiting to happen. Too bad libdbi does not support
prepared statements - I wish we co
Review at https://gerrit.osmocom.org/5205
db: wrap dbi querying to log actual SQL on debug and error
To be able to tell at all which DB query failed without introspecting the code
in gdb or similar, wrap the database query functions in local shims that log
the SQL.
Related: OS#2667, OS#2706
Ch
