[MERGED] osmo-msc[master]: msc_mgcp: Add FSM event names

2018-02-26 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: msc_mgcp: Add FSM event names .. msc_mgcp: Add FSM event names The FSM (fsm_msc_mgcp) lacks a proper definition of the FSM event names. This causes probl

osmo-msc[master]: msc_mgcp: Add FSM event names

2018-02-26 Thread Harald Welte
Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/6947 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6823756a63b08a71e5518130e49751aa073dbcd2 Gerrit-PatchSet: 2 Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit

[PATCH] osmo-msc[master]: msc_mgcp: Add FSM event names

2018-02-26 Thread dexter
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/6947 to look at the new patch set (#2). msc_mgcp: Add FSM event names The FSM (fsm_msc_mgcp) lacks a proper definition of the FSM event names. This causes problems when inspecting the FSM us

osmo-msc[master]: msc_mgcp: Add FSM event names

2018-02-26 Thread Harald Welte
Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/6947/1/src/libmsc/msc_mgcp.c File src/libmsc/msc_mgcp.c: Line 138: {EV_INIT, "EV_INIT"}, if the enum name and the string name are identical (which only makes sense in short names like here), you can (and should) use OSMO_VALUE_STRIN

[PATCH] osmo-msc[master]: msc_mgcp: Add FSM event names

2018-02-26 Thread dexter
Review at https://gerrit.osmocom.org/6947 msc_mgcp: Add FSM event names The FSM (fsm_msc_mgcp) lacks a proper definition of the FSM event names. This causes problems when inspecting the FSM using the VTY. - Add proper FSM Event names Closes: OS#2924 Change-Id: I6823756a63b08a71e5518130e49751