Patch Set 1:
let's continue discussing this in
https://osmocom.org/issues/2740
--
To view, visit https://gerrit.osmocom.org/5265
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib8993c8db171d1e845a6297deef137d18506cda3
Gerrit-PatchSet: 1
Patch Set 1:
stackoverflow has
#define __FILENAME__ (strrchr(__FILE__, '/') ? strrchr(__FILE__, '/') + 1 :
__FILE__)
which would iterate around in file paths for each log statement. compared to
terminal output that's probably neglectable.
--
To view, visit https://gerrit.osmocom.org/5265
Patch Set 1:
"__BASE_FILE__
This macro expands to the name of the main input file, in the form of a C
string constant. This is the source file that was specified on the command line
of the preprocessor or C compiler.
"
So it's not related to stripping path elements. If we did something li
Patch Set 1:
> Why do we see ../../../ in the file names? We switched logging to
> __BASE_FILE__ to avoid this on src vs. build dir builds..
I have no idea, maybe __BASE_FILE__ isn't working out as expected? I build in
this dir topology and usually see the long ../../ paths:
./src/osmo-foo
Patch Set 1:
Why do we see ../../../ in the file names? We switched logging to __BASE_FILE__
to avoid this on src vs. build dir builds..
--
To view, visit https://gerrit.osmocom.org/5265
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I
Harald Welte has submitted this change and it was merged.
Change subject: sms.db: silence libdbi warnings on out-of-range index
..
sms.db: silence libdbi warnings on out-of-range index
Apparently, since libdbi 0.9.0 aka 0.9.0-5
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/5265
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib8993c8db171d1e845a6297deef137d18506cda3
Gerrit-PatchSet: 1
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit
Review at https://gerrit.osmocom.org/5265
sms.db: silence libdbi warnings on out-of-range index
Apparently, since libdbi 0.9.0 aka 0.9.0-5 on debian-testing, osmo-msc barfs
numerous libdbi warnings whenever a query rightfully returns no rows.
Trivially query whether there are any rows first by
