Max has submitted this change and it was merged.
Change subject: Remove unused code
..
Remove unused code
The socket.* is unused leftover from pre-split time.
Fixes: CID57645
Change-Id
-Id: Ic39e848da47dc11357782362fdf6206d2c1457c2
Gerrit-PatchSet: 5
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Owner: Max
Gerrit-Reviewer: Harald Welte
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Max
Gerrit-HasComments: Yes
Hello Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/3895
to look at the new patch set (#21).
TS alloc: expand tests log
* restructure code for easier reading
* use consistent formatting for output
* log essential allocation para
continue;
--
To view, visit https://gerrit.osmocom.org/4086
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I31600462e48d945bc8b7abf86a3718ac83e1dcbb
Gerrit-PatchSet: 4
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Owner: Max
Gerrit-Reviewer: Harald Welte
Gerrit-Reviewer: Jenkins Builder
errit-Branch: master
Gerrit-Owner: Max
Gerrit-Reviewer: Harald Welte
Gerrit-Reviewer: Jenkins Builder
tchset
Gerrit-Change-Id: Ia13855877b2145cb57b1646f5562b2af3b87bcfb
Gerrit-PatchSet: 9
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Owner: Max
Gerrit-Reviewer: Harald Welte
Gerrit-Reviewer: Holger Freyther
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Max
chset
Gerrit-Change-Id: Ia13855877b2145cb57b1646f5562b2af3b87bcfb
Gerrit-PatchSet: 10
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Owner: Max
Gerrit-Reviewer: Harald Welte
Gerrit-Reviewer: Holger Freyther
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Max
Hello Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/3895
to look at the new patch set (#22).
TS alloc: expand tests log
* restructure code for easier reading
* use consistent formatting for output
* log essential allocation para
ettings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Icdde701839e35d3131605ea5a11882af21c8939a
Gerrit-PatchSet: 1
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Owner: Max
Max has submitted this change and it was merged.
Change subject: TS alloc: print suggested TRX on allocation errors
..
TS alloc: print suggested TRX on allocation errors
If TS allocation fails due to unavailable TFI, print TRX
Max has submitted this change and it was merged.
Change subject: Simplify TS alloc: internalize TRX check
..
Simplify TS alloc: internalize TRX check
Move TRX check inside local tfi_find_free() wrapper to make main
algorithm
for DL
-- Reserved DL/UL slots: (TS=0)"C..."(TS=7)
+- Reserved DL/UL slots: (TS=0)"...DC..."(TS=7)
- Assigning DL TS 4
PDCH(TS 4, TRX 0): Attaching TBF(TFI=0 TLLI=0x DIR=DL STATE=NULL
EGPRS), 1 TBFs, USFs = 00, TFIs = 0001.
TBF(TFI=0 TLLI=0x DIR=DL STAT
it https://gerrit.osmocom.org/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ifd88fc7ff818ea2a041eae61c5d457926a0df0f2
Gerrit-PatchSet: 9
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Owner: Max
Gerrit-Reviewer: Harald Welte
Gerrit-Reviewer: Jenkins Builder
nt8_t *dl_slots)
{
uint8_t Tx = mslot_class_get_tx(mslot_class), /* Max number of Tx
slots */
- Sum = mslot_class_get_sum(mslot_class); /* Max number of Tx +
Rx slots */
- int rx_window, tx_window, pdch_slots;
+ Sum = mslot_class_get_sum(mslot_class), /
, Sum;/* Maximum Number of Slots: RX, Tx, Sum Rx+Tx */
- uint8_t Tta, Ttb, Tra, Trb; /* Minimum Number of Slots */
- uint8_t Type; /* Type of Mobile */
+ uint8_t Tx = mslot_class_get_tx(mslot_class), /* Max number of Tx
slots */
+ Sum = mslot_class_get_sum(mslot_
Hello Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/3895
to look at the new patch set (#24).
TS alloc: expand tests log
* restructure code for easier reading
* use consistent formatting for output
* log essential allocation para
TBFs, USFs = 00, TFIs = 0001.
TBF(TFI=0 TLLI=0x DIR=DL STATE=NULL EGPRS) Setting Control TS 4
--
To view, visit https://gerrit.osmocom.org/3905
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I64cf78c5cfc78664766f9769dd5cde632dab92b0
Gerrit-PatchSet: 14
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Owner: Max
Gerrit-Reviewer: Harald Welte
Gerrit-Reviewer: Holger Freyther
Gerrit-Reviewer: Jenkins Builder
--- a/src/mslot_class.h
+++ b/src/mslot_class.h
@@ -49,5 +49,7 @@
uint8_t mslot_class_get_type(uint8_t ms_cl);
uint8_t mslot_class_max();
+/* multislot allocation helper routines */
void mslot_fill_rx_mask(uint8_t mslot_class, uint8_t num_tx, uint8_t *rx_mask);
int8_t find_free_usf(uint8_t usf_map);
+void masked_override_with(char *buf, uint8_t mask, char set_char);
--
To view, visit https://gerrit.osmocom.org/3906
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ied45ae380c345bc76fe9d6fd9a6184d1109f83f2
Gerrit-PatchSet: 16
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Owner: Max
Gerrit-Reviewer: Harald Welte
Gerrit-Reviewer: Jenkins Builder
/3929
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ia13855877b2145cb57b1646f5562b2af3b87bcfb
Gerrit-PatchSet: 12
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Owner: Max
Gerrit-Reviewer: Harald Welte
Gerrit-Reviewer: Holger Freyther
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Max
*! Find set of slots available for allocation while taking MS class into
account
*
* \param[in] trx Pointer to TRX object
@@ -475,9 +484,8 @@
Sum = mslot_class_get_sum(mslot_class); /* Max number of Tx +
Rx slots */
int rx_window, tx_window, pdch_slots;
lots(struct gprs_rlcmac_trx *trx, uint8_t mslot_class, uint8_t
*ul_slots, uint8_t *dl_slots)
{
uint8_t Tx = mslot_class_get_tx(mslot_class), /* Max number of Tx
slots */
- Sum = mslot_class_get_sum(mslot_class); /* Max number of Tx +
Rx slots */
- int rx_window, tx
d_ul_slots, &slotcount,
&avail_count);
--
To view, visit https://gerrit.osmocom.org/3930
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I563dc10827ce68295553f88f3bf2e1fc0ba595c1
Gerrit-PatchSet: 11
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Owner: Max
Gerrit-Reviewer: Harald Welte
Gerrit-Reviewer: Holger Freyther
Gerrit-Reviewer: Jenkins Builder
: newchange
Gerrit-Change-Id: Ie154866900453d232a890f7b9a30911b451525a1
Gerrit-PatchSet: 1
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Owner: Max
Review at https://gerrit.osmocom.org/6224
Simplify TS alloc: constify max dl slot func
Constify parameters of gprs_alloc_max_dl_slots_per_ms().
Change-Id: Ic90930d98560459eab0054cb9e1625cb99db61c8
Related: OS#2282
---
M src/gprs_rlcmac.h
M src/gprs_rlcmac_ts_alloc.cpp
2 files changed, 2
change
Gerrit-Change-Id: I75e33c38accdf2a0af961c89836c5e7a3a056bda
Gerrit-PatchSet: 1
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Owner: Max
92
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I12234d37c66b83b8abd60f7511fa1d7837db1856
Gerrit-PatchSet: 1
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Owner: Max
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Max
Gerrit-Reviewer: Vadim Yanitskiy
Gerrit-Reviewer: fixeria
Gerrit-HasComments: Yes
@@
ul_tbf = establish_ul_tbf_two_phase_spb(&the_bts, ts_no, tlli, &fn, qta,
ms_class, egprs_ms_class);
- ms = ul_tbf->ms();
- fprintf(stderr, "Got '%s', TA=%d\n", ul_tbf->name(), ul_tbf->ta());
- fprintf(stderr,
- "Got MS: TLLI = 0x%08x, TA = %d\n", ms->tlli(), ms->ta());
-
+ print_ta_tlli(ul_tbf, true);
send_dl_data(&the_bts, tlli, imsi, test_data, sizeof(test_data));
printf("=== end %s ===\n", __func__);
@@ -2626,7 +2588,6 @@
uint8_t ms_class = 1;
uint8_t egprs_ms_class = 1;
gprs_rlcmac_ul_tbf *ul_tbf;
- GprsMs *ms;
uint8_t test_data[256];
printf("=== start %s ===\n", __func__);
@@ -2640,10 +2601,7 @@
ul_tbf = establish_ul_tbf_two_phase(&the_bts, ts_no, tlli, &fn, qta,
ms_class, egprs_ms_class);
- ms = ul_tbf->ms();
- fprintf(stderr, "Got '%s', TA=%d\n", ul_tbf->name(), ul_tbf->ta());
- fprintf(stderr, "Got MS: TLLI = 0x%08x, TA = %d\n", ms->tlli(),
ms->ta());
-
+ print_ta_tlli(ul_tbf, true);
send_dl_data(&the_bts, tlli, imsi, test_data, sizeof(test_data));
printf("=== end %s ===\n", __func__);
--
To view, visit https://gerrit.osmocom.org/6240
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I1c4ad1dc94542835f15bd666f0821e0ccfcc78c1
Gerrit-PatchSet: 1
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Owner: Max
s_data);
int pcu_vty_show_ms_by_tlli(struct vty *vty, struct gprs_rlcmac_bts *bts_data,
uint32_t tlli);
--
To view, visit https://gerrit.osmocom.org/6239
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I80f8df4fe663a0346f4289a4220b761e39726312
Gerrit-PatchSet: 1
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Owner: Max
it-MessageType: newchange
Gerrit-Change-Id: Ie411ea2bbfca442b33405584f15687a7ffcbb53c
Gerrit-PatchSet: 1
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Owner: Max
Gerrit-Owner: Max
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Max
Gerrit-Reviewer: fixeria
Gerrit-Reviewer: tnt
Gerrit-HasComments: No
-MessageType: comment
Gerrit-Change-Id: If2263a82a6c71475cb6ea8f9158a0e758abfd995
Gerrit-PatchSet: 1
Gerrit-Project: gapk
Gerrit-Branch: master
Gerrit-Owner: Vadim Yanitskiy
Gerrit-Reviewer: Max
Gerrit-HasComments: No
-Owner: Vadim Yanitskiy
Gerrit-Reviewer: Harald Welte
Gerrit-Reviewer: Max
Gerrit-HasComments: No
visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2a9982f221871c78c5c9a73b7b7a1787ff07a86c
Gerrit-PatchSet: 1
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Owner: Vadim Yanitskiy
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Max
Gerrit-HasCom
Gerrit-Owner: Pau Espin Pedrol
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Max
Gerrit-Reviewer: Vadim Yanitskiy
Gerrit-HasComments: No
errit-Change-Id: I736c1e4d625f647d3bb794fa717256e9dbf36e87
Gerrit-PatchSet: 1
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Owner: Pau Espin Pedrol
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Max
Gerrit-Reviewer: Vadim Yanitskiy
Gerrit-HasComments: No
://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I237c6898cb7bbccb891e23ebab08498768a01574
Gerrit-PatchSet: 1
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Owner: Vadim Yanitskiy
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Max
Gerrit-Reviewer: tnt
Gerrit
ge-Id: Ie7cd648a4b8a5ae59efc8953d6424a91a0f025ef
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Owner: Pau Espin Pedrol
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Max
Gerrit-Reviewer: Vadim Yanitskiy
Gerrit-HasComments: No
Gerrit-Owner: Vadim Yanitskiy
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Max
Gerrit-HasComments: No
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/6270
to look at the new patch set (#2).
Turn libosmo-mgcp into local, non-installed library
This is an internal library simmilar to 'libmsc' in osmo-msc, which
we don't expect to be used by
keep this
one in gerrit till than as a reminder.
--
To view, visit https://gerrit.osmocom.org/4086
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I31600462e48d945bc8b7abf86a3718ac83e1dcbb
Gerrit-PatchSet: 7
Gerrit-Project: osmo-pcu
Ger
To view, visit https://gerrit.osmocom.org/6239
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I80f8df4fe663a0346f4289a4220b761e39726312
Gerrit-PatchSet: 1
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Owner: Max
Gerrit-Reviewer: Hara
estamp in the message, irrespective
--
To view, visit https://gerrit.osmocom.org/6197
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I03d0d3d32a8d572ad573d03c603e14cdc27a3f7b
Gerrit-PatchSet: 2
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Owner: Max
Gerrit-Reviewer: Harald Welte
Gerrit-Reviewer: Jenkins Builder
Max has submitted this change and it was merged.
Change subject: utils: add helper wrapper for osmo_strlcpy()
..
utils: add helper wrapper for osmo_strlcpy()
Add wrapper for osmo_strlcpy() which uses sizeof() to automatically
vsub->imsi, vsub->imeisv);
}
@@ -397,7 +397,7 @@
{
if (!vsub)
return;
- osmo_strlcpy(vsub->msisdn, msisdn, sizeof(vsub->msisdn));
+ OSMO_STRLCPY_ARRAY(vsub->msisdn, msisdn);
DEBUGP(DVLR, "set MSISDN on subscriber; IMSI=%s MSISDN=%s\n",
vsub->imsi, vsub->msisdn);
}
@@ -566,7 +566,7 @@
struct osmo_gsup_message gsup_msg = {0};
gsup_msg.message_type = OSMO_GSUP_MSGT_AUTH_FAIL_REPORT;
- osmo_strlcpy(gsup_msg.imsi, vsub->imsi, sizeof(gsup_msg.imsi));
+ OSMO_STRLCPY_ARRAY(gsup_msg.imsi, vsub->imsi);
return vlr_tx_gsup_message(vsub->vlr, &gsup_msg);
}
--
To view, visit https://gerrit.osmocom.org/6198
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I67b482dedfa11237ac21894fc5930039e12434ab
Gerrit-PatchSet: 2
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Owner: Max
Gerrit-Reviewer: Jenkins Builder
Max has submitted this change and it was merged.
Change subject: GSUP: change osmo_gsup_encode() return type
..
GSUP: change osmo_gsup_encode() return type
* match return type of osmo_gsup_encode() with osmo_gsup_decode() to
29
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ia13855877b2145cb57b1646f5562b2af3b87bcfb
Gerrit-PatchSet: 13
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Owner: Max
Gerrit-Reviewer: Harald Welte
Gerrit-Reviewer: Holger Freyther
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Max
b9a30911b451525a1
Gerrit-PatchSet: 2
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Owner: Max
Gerrit-Reviewer: Jenkins Builder
* \param[in] trx Pointer to TRX object
@@ -467,16 +511,12 @@
int find_multi_slots(struct gprs_rlcmac_trx *trx, uint8_t mslot_class, uint8_t
*ul_slots, uint8_t *dl_slots)
{
uint8_t Tx = mslot_class_get_tx(mslot_class), /* Max number of Tx
slots */
- Sum = mslot_
, Sum;/* Maximum Number of Slots: RX, Tx, Sum Rx+Tx */
- uint8_t Tta, Ttb, Tra, Trb; /* Minimum Number of Slots */
- uint8_t Type; /* Type of Mobile */
+ uint8_t Tx = mslot_class_get_tx(mslot_class), /* Max number of Tx
slots */
+ Sum = mslot_class_get_sum(mslot_
DIR=$BASEDIR/titan.TestPorts.Common_Components.Socket-API/src
--
To view, visit https://gerrit.osmocom.org/6275
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I10309f07fb207c027703f0b43a478c152a029b6d
Gerrit-PatchSet: 1
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Owner: Max
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib94dbe65fa2ae53d95b3f0524af77b1303e33ce3
Gerrit-PatchSet: 1
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Owner: Max
: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Owner: Max
Gerrit-Reviewer: Harald Welte
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Pau Espin Pedrol
ssageType: comment
Gerrit-Change-Id: I12234d37c66b83b8abd60f7511fa1d7837db1856
Gerrit-PatchSet: 6
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Owner: Max
Gerrit-Reviewer: Harald Welte
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Max
Gerrit-Reviewer: Vadim Yanitskiy
Gerrit-Reviewer: fixeria
Gerrit-HasComments: No
7df46
Gerrit-PatchSet: 1
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Owner: dexter
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Max
Gerrit-HasComments: No
Max has abandoned this change.
Change subject: Fix regen_makefile warning
..
Abandoned
--
To view, visit https://gerrit.osmocom.org/6276
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: abandon
unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia200e7e8e891256f0ffe43910061697769841f91
Gerrit-PatchSet: 1
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Owner: Max
ge-Id: Ia200e7e8e891256f0ffe43910061697769841f91
Gerrit-PatchSet: 2
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Owner: Max
Gerrit-Reviewer: Harald Welte
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter
-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Owner: Pau Espin Pedrol
Gerrit-Reviewer: Harald Welte
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Max
Gerrit-Reviewer: Neels Hofmeyr
Gerrit-Reviewer: Pau Espin Pedrol
Gerrit-HasComments: No
tefan Sperling
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Max
Gerrit-HasComments: Yes
-122,7 +122,7 @@
int run_test_nr;
};
-typedef void (* msc_vlr_test_func_t )(void);
+typedef void (* msc_vlr_test_func_t )(const char *);
extern msc_vlr_test_func_t msc_vlr_tests[];
struct msgb *msgb_from_hex(const char *label, uint16_t size, const char *hex);
--
To view, visit https://gerrit.osmocom.org/6288
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I74d46fdb7e87dc04c6b82a0b6f3ce6bef60bde58
Gerrit-PatchSet: 1
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Owner: Max
if (!conn_exists(conn))
+ fprintf(stderr, "ERROR: expecting %s on unknown
connection\n",
+ exp ? "true" : "false");
+
+ accepted = msc_subscr_conn_is_accepted(conn);
+ fprintf(stderr, "msc_subscr_conn_is_accepted() == %s%s\n",
+ accepted ? "true" : "false", accepted != exp ? " EXP. FAILED!"
: "");
}
enum ran_type rx_from_ran = RAN_GERAN_A;
@@ -210,7 +228,7 @@
ran_type_name(rx_from_ran),
gh_type_name(gh));
- if (g_conn && !conn_exists(g_conn))
+ if (!conn_exists(g_conn))
g_conn = NULL;
if (!g_conn) {
@@ -232,7 +250,7 @@
msc_dtap(g_conn, 23, msg);
}
- if (g_conn && !conn_exists(g_conn))
+ if (!conn_exists(g_conn))
g_conn = NULL;
}
diff --git a/tests/msc_vlr/msc_vlr_tests.h b/tests/msc_vlr/msc_vlr_tests.h
index 2ea3f29..0d48e00 100644
--- a/tests/msc_vlr/msc_vlr_tests.h
+++ b/tests/msc_vlr/msc_vlr_tests.h
@@ -128,7 +128,8 @@
struct msgb *msgb_from_hex(const char *label, uint16_t size, const char *hex);
void clear_vlr();
-bool conn_exists(struct gsm_subscriber_connection *conn);
+
+void exp_accept_con(bool exp, const struct gsm_subscriber_connection *conn);
void dtap_expect_tx(const char *hex);
void dtap_expect_tx_ussd(char *ussd_text);
@@ -143,15 +144,6 @@
char *str);
void thwart_rx_non_initial_requests();
-
-#define EXPECT_ACCEPTED(expect_accepted) do { \
- if (g_conn) \
- OSMO_ASSERT(conn_exists(g_conn)); \
- bool accepted = msc_subscr_conn_is_accepted(g_conn); \
- fprintf(stderr, "msc_subscr_conn_is_accepted() == %s\n", \
- accepted ? "true" : "false"); \
- OSMO_ASSERT(accepted == expect_accepted); \
- } while (false)
#define VERBOSE_ASSERT(val, expect_op, fmt) \
do { \
--
To view, visit https://gerrit.osmocom.org/6296
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I36ae1f9bb395921dc2c5a39e35fbb8040ba47213
Gerrit-PatchSet: 1
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Owner: Max
.osmocom.org/6294
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I5eac4c24257fd38068ba629d3c21848181703220
Gerrit-PatchSet: 1
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Owner: Max
m.org/6297
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I7958608e5136351f7b7c0c57fe79791d989ce9c3
Gerrit-PatchSet: 1
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Owner: Max
/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I8af50a8847a5b438cf2ef660399d4c8bbac86a71
Gerrit-PatchSet: 1
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Owner: Max
-Owner: lynxis lazus
Gerrit-Reviewer: Harald Welte
Gerrit-Reviewer: Holger Freyther
Gerrit-Reviewer: Max
Gerrit-Reviewer: lynxis lazus
Gerrit-Reviewer: neels
Gerrit-HasComments: No
com.org/6303
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibf4fca0bd42dfe5bc63e8b08754ebbe0a5e252c3
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Owner: dexter
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer:
*receiver,
--
To view, visit https://gerrit.osmocom.org/6304
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I2607cb1ac60941dbc22fca532ed2b3738bfbcc63
Gerrit-PatchSet: 1
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Owner: Max
v)
--
To view, visit https://gerrit.osmocom.org/6305
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I1f571ec319ff3231fd9acd4066e470476c3b1f78
Gerrit-PatchSet: 1
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Owner: Max
!conn)
return false;
--
To view, visit https://gerrit.osmocom.org/6295
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I8af50a8847a5b438cf2ef660399d4c8bbac86a71
Gerrit-PatchSet: 2
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Owner
quot;);
+
+ accepted = msc_subscr_conn_is_accepted(conn);
+ fprintf(stderr, "msc_subscr_conn_is_accepted() == %s%s\n",
+ accepted ? "true" : "false", accepted != exp ? " EXP. FAILED!"
: "");
}
enum ran_type rx_from_ran = RAN_GERAN_A;
@@ -210,7 +228,7 @@
ran_type_name(rx_from_ran),
gh_type_name(gh));
- if (g_conn && !conn_exists(g_conn))
+ if (!conn_exists(g_conn))
g_conn = NULL;
if (!g_conn) {
@@ -232,7 +250,7 @@
msc_dtap(g_conn, 23, msg);
}
- if (g_conn && !conn_exists(g_conn))
+ if (!conn_exists(g_conn))
g_conn = NULL;
}
diff --git a/tests/msc_vlr/msc_vlr_tests.h b/tests/msc_vlr/msc_vlr_tests.h
index 2ea3f29..0d48e00 100644
--- a/tests/msc_vlr/msc_vlr_tests.h
+++ b/tests/msc_vlr/msc_vlr_tests.h
@@ -128,7 +128,8 @@
struct msgb *msgb_from_hex(const char *label, uint16_t size, const char *hex);
void clear_vlr();
-bool conn_exists(struct gsm_subscriber_connection *conn);
+
+void exp_accept_con(bool exp, const struct gsm_subscriber_connection *conn);
void dtap_expect_tx(const char *hex);
void dtap_expect_tx_ussd(char *ussd_text);
@@ -143,15 +144,6 @@
char *str);
void thwart_rx_non_initial_requests();
-
-#define EXPECT_ACCEPTED(expect_accepted) do { \
- if (g_conn) \
- OSMO_ASSERT(conn_exists(g_conn)); \
- bool accepted = msc_subscr_conn_is_accepted(g_conn); \
- fprintf(stderr, "msc_subscr_conn_is_accepted() == %s\n", \
- accepted ? "true" : "false"); \
- OSMO_ASSERT(accepted == expect_accepted); \
- } while (false)
#define VERBOSE_ASSERT(val, expect_op, fmt) \
do { \
--
To view, visit https://gerrit.osmocom.org/6296
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I36ae1f9bb395921dc2c5a39e35fbb8040ba47213
Gerrit-PatchSet: 2
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Owner: Max
Gerrit-Reviewer: Harald Welte
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel
Gerrit-PatchSet: 2
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Owner: Max
Gerrit-Reviewer: Harald Welte
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel
+ run_tests(nr, "90170004620");
}
}
--
To view, visit https://gerrit.osmocom.org/6297
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7958608e5136351f7b7c0c57fe79791d989ce9c3
Gerrit-PatchSet: 2
Gerrit-P
2ed2b3738bfbcc63
Gerrit-PatchSet: 2
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Owner: Max
Gerrit-Reviewer: Jenkins Builder
+ run_tests(nr, "90170004620");
}
}
--
To view, visit https://gerrit.osmocom.org/6297
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7958608e5136351f7b7c0c57fe79791d989ce9c3
Gerrit-PatchSet: 3
Gerrit-P
com.org/6305
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I1f571ec319ff3231fd9acd4066e470476c3b1f78
Gerrit-PatchSet: 2
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Owner: Max
Gerrit-Reviewer: Harald Welte
Gerrit-Reviewer: Jenkins
quot;);
+
+ accepted = msc_subscr_conn_is_accepted(conn);
+ fprintf(stderr, "msc_subscr_conn_is_accepted() == %s%s\n",
+ accepted ? "true" : "false", accepted != exp ? " EXP. FAILED!"
: "");
}
enum ran_type rx_from_ran = RAN_GERAN_A;
@@ -210,7 +228,7 @@
ran_type_name(rx_from_ran),
gh_type_name(gh));
- if (g_conn && !conn_exists(g_conn))
+ if (!conn_exists(g_conn))
g_conn = NULL;
if (!g_conn) {
@@ -232,7 +250,7 @@
msc_dtap(g_conn, 23, msg);
}
- if (g_conn && !conn_exists(g_conn))
+ if (!conn_exists(g_conn))
g_conn = NULL;
}
diff --git a/tests/msc_vlr/msc_vlr_tests.h b/tests/msc_vlr/msc_vlr_tests.h
index 2ea3f29..0d48e00 100644
--- a/tests/msc_vlr/msc_vlr_tests.h
+++ b/tests/msc_vlr/msc_vlr_tests.h
@@ -128,7 +128,8 @@
struct msgb *msgb_from_hex(const char *label, uint16_t size, const char *hex);
void clear_vlr();
-bool conn_exists(struct gsm_subscriber_connection *conn);
+
+void exp_accept_con(bool exp, const struct gsm_subscriber_connection *conn);
void dtap_expect_tx(const char *hex);
void dtap_expect_tx_ussd(char *ussd_text);
@@ -143,15 +144,6 @@
char *str);
void thwart_rx_non_initial_requests();
-
-#define EXPECT_ACCEPTED(expect_accepted) do { \
- if (g_conn) \
- OSMO_ASSERT(conn_exists(g_conn)); \
- bool accepted = msc_subscr_conn_is_accepted(g_conn); \
- fprintf(stderr, "msc_subscr_conn_is_accepted() == %s\n", \
- accepted ? "true" : "false"); \
- OSMO_ASSERT(accepted == expect_accepted); \
- } while (false)
#define VERBOSE_ASSERT(val, expect_op, fmt) \
do { \
--
To view, visit https://gerrit.osmocom.org/6296
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I36ae1f9bb395921dc2c5a39e35fbb8040ba47213
Gerrit-PatchSet: 3
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Owner: Max
Gerrit-Reviewer: Harald Welte
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel
2ed2b3738bfbcc63
Gerrit-PatchSet: 3
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Owner: Max
Gerrit-Reviewer: Jenkins Builder
Review at https://gerrit.osmocom.org/6307
VLR tests: always print test parameters
For each test print:
* the test number
* IMSI
Unfortunately tests are organized in such a way that we don't know the
number of particular test in advance. Nevertheless, it make sense to
always print it regardless
if (!conn_exists(conn))
+ fprintf(stderr, "ERROR: expecting %s on unknown
connection\n",
+ exp ? "true" : "false");
+
+ accepted = msc_subscr_conn_is_accepted(conn);
+ fprintf(stderr,
o belong here
Indeed.
--
To view, visit https://gerrit.osmocom.org/6296
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I36ae1f9bb395921dc2c5a39e35fbb8040ba47213
Gerrit-PatchSet: 1
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Owner
rg/6308
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I5962431ad16c97e412939dc1b8949f6361a5c26e
Gerrit-PatchSet: 1
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Owner: Max
r->cfg.is_ps);
+ rc = vlr_subscr_req_lu(vsub, vsub->vlr->cfg.is_ps);
+ if (rc < 0)
+ LOGPFSML(fi, LOGL_ERROR, "Failed to send UpdateLocation to
HLR\n");
osmo_fsm_inst_state_chg(fi, UPD_HLR_VLR_S_WAIT_FOR_DATA,
rrit-PatchSet: 5
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Owner: Max
Gerrit-Reviewer: Harald Welte
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Max
Gerrit-Reviewer: daniel
truct msgb *msgb_from_hex(const char *label, uint16_t size, const char *hex);
--
To view, visit https://gerrit.osmocom.org/6288
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I74d46fdb7e87dc04c6b82a0b6f3ce6bef60bde58
Gerrit-PatchSet: 3
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Owner: Max
Gerrit-Reviewer: Harald Welte
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel
ode_cmd;
+ msc_subscr_conn_init();
clear_vlr();
--
To view, visit https://gerrit.osmocom.org/6311
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I68a2e94cf79fcb83286eef981a8d88bdbe10ef69
Gerrit-PatchSet: 1
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Owner: Max
SMO_ASSERT(event == UPD_HLR_VLR_E_START);
/* Send UpdateLocation to HLR */
- vlr_subscr_req_lu(vsub, vsub->vlr->cfg.is_ps);
+ rc = vlr_subscr_req_lu(vsub, vsub->vlr->cfg.is_ps);
+ if (rc < 0)
+ LOGPFSML(fi, LOGL_ERROR, "Failed to send Up
LOGP(DRLCMAC, LOGL_ERROR, "PCU has not received burst type from
BTS\n");
+ break;
+ default:
+ LOGP(DRLCMAC, LOGL_ERROR, "Unexpected RACH burst type %u for
%s-bit RACH\n",
+burst_type, is_11bit ? "11" : "8");
}
return sb;
--
To view, visit https://gerrit.osmocom.org/6312
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I9180478152f9341f11bb3dffe61671da683f24d8
Gerrit-PatchSet: 1
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Owner: Max
visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia28741603636406744e5e221fb7a9689955a
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Owner: Max
errit-PatchSet: 1
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Owner: Max
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Max
Gerrit-HasComments: No
gs
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib539a8739d53ab60d8fadffcef38152b82a28498
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Owner: Max
l1sap_up(l1t->trx, &l1sap);
--
To view, visit https://gerrit.osmocom.org/6315
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ia28741603636406744e5e221fb7a9689955a
Gerrit-PatchSet: 2
Gerrit-Project: osmo-bts
Gerri
Max has submitted this change and it was merged.
Change subject: RACH: improve single block detection
..
RACH: improve single block detection
Replace unreadable if-else ladder in is_single_block() with regular
switch-case
rit-Change-Id: Ia200e7e8e891256f0ffe43910061697769841f91
Gerrit-PatchSet: 2
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Owner: Max
Gerrit-Reviewer: Harald Welte
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Max
Gerrit-Reviewer: dexter
Gerrit-HasComments: No
Gerrit-Owner: Vadim Yanitskiy
Gerrit-Reviewer: Harald Welte
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Max
Gerrit-Reviewer: Vadim Yanitskiy
Gerrit-HasComments: No
the current GSM time */
--
To view, visit https://gerrit.osmocom.org/6322
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I4f7cf285e437db0e980e1a2a3ab48a7255945448
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Owner: Max
ocom.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iaf85826861163c185925de528c8347ab22779e30
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Owner: Max
Gerrit-Owner: Harald Welte
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Max
Gerrit-HasComments: No
ent
Gerrit-Change-Id: Ia28741603636406744e5e221fb7a9689955a
Gerrit-PatchSet: 2
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Owner: Max
Gerrit-Reviewer: Harald Welte
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Max
Gerrit-Reviewer: Vadim Yanitskiy
Gerrit-HasComments: No
ge-Id: Ia200e7e8e891256f0ffe43910061697769841f91
Gerrit-PatchSet: 3
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Owner: Max
Gerrit-Reviewer: Harald Welte
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Max
Gerrit-Reviewer: dexter
smocom.org/6285
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia200e7e8e891256f0ffe43910061697769841f91
Gerrit-PatchSet: 3
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Owner: Max
Gerrit-Reviewer: Harald Welte
Gerrit-Re
901 - 1000 of 3841 matches
Mail list logo
