[Getfem-commits] [getfem-commits] touched_region_for_projected_fem updated (e13a082 -> 3c95fe3)

2021-03-04 Thread Andriy Andreykiv
andrico pushed a change to branch touched_region_for_projected_fem. from e13a082 projected_fem::touched_target_region() new 9c0058d less auto new 3c95fe3 comment spelling Summary of changes: src/getfem/getfem_projected_fem.h | 2 +- src/getfem_projected_fem.cc | 12 +

Re: [Getfem-commits] merge request for touched_region_for_projected_fem

2021-03-04 Thread Andriy Andreykiv
Hi Konstantinos, Replaced almost all the auto's. Regarding intersected_target_region, that could be, but for me the word intersected would be appropriate if it was interpolated_fem where the regions intersect. Physically it feels like touch, but I agree that we have touch() in context_dependencies

[Getfem-commits] (no subject)

2021-03-04 Thread Andriy Andreykiv
branch: touched_region_for_projected_fem commit 9c0058d2398da11a148029e0b4fad00d1d853e00 Author: Andriy Andreykiv AuthorDate: Thu Mar 4 13:57:21 2021 +0100 less auto --- src/getfem_projected_fem.cc | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/src/getfem_pr

[Getfem-commits] (no subject)

2021-03-04 Thread Andriy Andreykiv
branch: touched_region_for_projected_fem commit 3c95fe39eb8b1a1b4de5ce6126729a02c2b1528e Author: Andriy Andreykiv AuthorDate: Thu Mar 4 13:58:21 2021 +0100 comment spelling --- src/getfem/getfem_projected_fem.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/getfem/ge

Re: [Getfem-commits] merge request for touched_region_for_projected_fem

2021-03-04 Thread Konstantinos Poulios via Getfem-commits
should we also briefly discuss the name of the function? In mathematical terms I would call it support_region But a more popularized name might be easier to understand in general. However, I do not like "touched" because "touch" is typically used in programming for denoting change in state, so yo

Re: [Getfem-commits] merge request for touched_region_for_projected_fem

2021-03-04 Thread Konstantinos Poulios via Getfem-commits
Hi Andriy, Thanks, I see how it can be useful. Could I ask you to reduce the use of auto for this commit? For example it does not make much sense to use auto for bool. In general my preference for the GetFEM codebase is to use auto only if some type is particularly long and makes the code signific

[Getfem-commits] merge request for touched_region_for_projected_fem

2021-03-04 Thread Andriy Andreykiv
Dear Yves and Konstantinus, Kind request to review and merge touched_region_for_projected_fem branch. It introduces a method for projected_fem that extracts a region from the target that is actually touched by the source. I use this region to integrate my mortar terms on. Best regards,