Re: Phabricator for patches and code review

2014-06-07 Thread Arash Rouhani
Could not have agreed more with Manuel. I would also like to point out that one of the missions of the arcanist tool is to support all version control systems. That have made sense for FaceBook Inc, who went from Subversion to Git to Mercurial. GHC team only use git now. I think the consequenc

Re: Phabricator for patches and code review

2014-06-07 Thread Mateusz Kowalczyk
On 06/07/2014 07:21 AM, Manuel M T Chakravarty wrote: > So, why not put everything on GutHub and use pull requests and so on? > > SimonM writes that Phabricator is better than GitHub. I’m happy to believe > that, but he also writes that using it requires installing local software and > quite a b

Re: Phabricator for patches and code review

2014-06-07 Thread Austin Seipp
This always gets brought up, but I (still) think there are several reasons to prefer our own infrastructure over GitHub: - Phab is far more flexible, especially for review. GitHub doesn't even have side-by-side diffs (a massive improvement), much less the suite of tools that make code review easy

Re: Phabricator for patches and code review

2014-06-07 Thread Austin Seipp
I don't think Arcanist forces any particular workflow after working with it a bit. Generally, all you have to do is checkout a branch, make some commits on that branch, and run 'arc diff'. Make more commits on that branch, run 'arc diff' again. When it's ready I can merge it however I want. This wo

Re: Phabricator for patches and code review

2014-06-07 Thread Arash Rouhani
Well, I'm convinced now that you have researched this thoroughly. Thanks for doing so and addressing mine and Manuel's concerns. Cheers, Arash On 2014-06-07 09:24, Austin Seipp wrote: This always gets brought up, but I (still) think there are several reasons to prefer our own infrastructure ov

Re: Offering GHC builder build slaves

2014-06-07 Thread Páli Gábor János
2014-06-07 0:17 GMT+02:00 Mateusz Kowalczyk : > I notice that the builds with failing > test results are still marked as successful. Would it not be useful to > indicate that there are failing tests somehow? The result is based on the value that the invoked command returns. That is, for the testin

Re: Offering GHC builder build slaves

2014-06-07 Thread Joachim Breitner
Hi, Am Samstag, den 07.06.2014, 12:21 +0200 schrieb Páli Gábor János: > 2014-06-07 0:17 GMT+02:00 Mateusz Kowalczyk : > > It'd be a shame to have > > various test results from multiple machines but not use them. > > I see what you mean. But I would also feel strange to mark the test > results fa

Re: 7.8.3 release - please speak up soon.

2014-06-07 Thread Gergely Risko
On Thu, 5 Jun 2014 22:27:30 +0300, Sergei Trofimovich writes: > Can you write what problems are to ship those libraries in it's current form? > Do you have some linking problems or something? > > Ticket does not describe any actual problems. Sorry for the two days of delay, I'm on Zurihac. I mo

Re: [GHC] #8226: Remove the old style -- # Haddock comments.

2014-06-07 Thread Alfredo Di Napoli
Thanks Fuuzetsu, Tomorrow I'll still be at the ZuriHac, so hopefully I'll able to adjust the patch :) I'll poke you if you'll be around Thanks! Alfredo Di Napoli > On 07/giu/2014, at 07:23, "GHC" wrote: > > #8226: Remove the old style -- # Haddock comments. > -

Re: GHC/cabal release procedures, and Stackage

2014-06-07 Thread Joachim Breitner
Hi Michael, Am Samstag, den 07.06.2014, 21:06 +0300 schrieb Michael Snoyman: > If there was a daily snapshot build, I would be happy to set up some > kind of regular process to download that snapshot and do a Stackage > run on it. I'm currently blocked on this kind of activity, since I > can't ge

Re: GHC/cabal release procedures, and Stackage

2014-06-07 Thread Mateusz Kowalczyk
On 06/07/2014 11:57 PM, Joachim Breitner wrote: > Hi Michael, > > Am Samstag, den 07.06.2014, 21:06 +0300 schrieb Michael Snoyman: > >> If there was a daily snapshot build, I would be happy to set up some >> kind of regular process to download that snapshot and do a Stackage >> run on it. I'm cur