Re: GitHub pull requests

2014-10-05 Thread Johan Tibell
At least for cabal there was a large uptick in contributions once we moved to GitHub. On Sun, Oct 5, 2014 at 7:03 AM, Ben Gamari bgamari.f...@gmail.com wrote: Richard Eisenberg e...@cis.upenn.edu writes: I've just finished reading this:

Re: GitHub pull requests

2014-10-05 Thread Herbert Valerio Riedel
On 2014-10-05 at 04:51:41 +0200, Richard Eisenberg wrote: I've just finished reading this: http://www.reddit.com/r/haskell/comments/2hes8m/the_ghc_source_code_contains_1088_todos_please/ For better or worse, I don't read reddit often enough to hold a conversation there, so I'll ask my

Re: GitHub pull requests

2014-10-05 Thread Andreas Abel
On 05.10.2014 07:03, Ben Gamari wrote: and yet aren't willing to take the five (twenty?) minutes to familiarize themselves with Phabricator and the arc toolchain. Are you serious about this? I think your time estimate is a grand illusion. I attended Joachim Breitner's talk about Phabricator

Re: GitHub pull requests

2014-10-05 Thread Michael Snoyman
On Sun, Oct 5, 2014 at 11:21 AM, Andreas Abel ab...@chalmers.se wrote: On 05.10.2014 07:03, Ben Gamari wrote: and yet aren't willing to take the five (twenty?) minutes to familiarize themselves with Phabricator and the arc toolchain. Are you serious about this? I think your time estimate

Re: GitHub pull requests

2014-10-05 Thread Joachim Breitner
Hi, we already have the problem with some people submitting diffs on trac, other submitting git patches on trac or linking to their private fork somewhere to pull from, and others using Phabricator. And, at least as far as I can tell from here, it doesn’t seem to be a big deal. So (warning:

Re: GitHub pull requests

2014-10-05 Thread Herbert Valerio Riedel
Hello, On 2014-10-05 at 14:03:41 +0200, Joachim Breitner wrote: Am Sonntag, den 05.10.2014, 13:08 +0200 schrieb Herbert Valerio Riedel: On 2014-10-05 at 12:56:28 +0200, Joachim Breitner wrote: [...] I think the advantage could outweigh the downside and it’s worth a try. We don’t even

Re: GitHub pull requests

2014-10-05 Thread Ben Gamari
Andreas Abel ab...@chalmers.se writes: On 05.10.2014 07:03, Ben Gamari wrote: and yet aren't willing to take the five (twenty?) minutes to familiarize themselves with Phabricator and the arc toolchain. Are you serious about this? I think your time estimate is a grand illusion. Fair

Re: GitHub pull requests

2014-10-05 Thread Joachim Breitner
Hi, Am Sonntag, den 05.10.2014, 19:20 +0200 schrieb Tuncer Ayaz: There's also the problem that Github's review system is not as powerful and most importantly does not preserve history like Gerrit or Phabricator do. Once used to it, maintainers probably won't be happy to lose productivity due

Re: GitHub pull requests

2014-10-05 Thread Gintautas Miliauskas
Is there any particular reason why taking in GitHub pull requests would be more problematic than, say, applying patches attached to Trac bugs? Both have to be dealt with manually by someone with commit rights for the canonical repository anyway. If the issue is important enough that, say, tracking

Re: Tentative high-level plans for 7.10.1

2014-10-05 Thread John Lato
Speaking as a user, I think Johan's concern is well-founded. For us, ghc-7.8.3 was the first of the 7.8 line that was really usable in production, due to #8960 and other bugs. Sure, that can be worked around in user code, but it takes some time for developers to locate the issues, track down the