Re: Action Required: Status of Harbormaster for Differentials

2016-08-30 Thread Richard Eisenberg
Hi Ben, Thanks for tackling this difficult issue -- I know you've been looking for a better solution. As I understand it, anyone will now need to add a public key to Phab in order to upload patches. This (as you admit) will increase the barriers to contributions. Are the instructions for how a

Re: Last call for merge requests for 8.0.2

2016-08-30 Thread Ben Gamari
Facundo Domínguez writes: > Hello Ben, > > Could we have these patches added? > > http://git.haskell.org/ghc.git/commit/56f47d4a4e418235285d8b8cfe23bde6473f17fc > http://git.haskell.org/ghc.git/commit/567dbd9bcb602accf3184b83050f2982cbb7758b > > These allow reify to reach local variables when u

Re: Last call for merge requests for 8.0.2

2016-08-30 Thread Boespflug, Mathieu
Depends how you look at it I guess. It's arguably a fix to addModFinalizer, which never really worked for the use case it was intended since it was first introduced. This function was added by the author of language-c-inline, who wanted things like cos :: Double -> Double cos x = [c| cos($x) |] t

Re: Action Required: Status of Harbormaster for Differentials

2016-08-30 Thread Ben Gamari
Richard Eisenberg writes: > Hi Ben, > > Thanks for tackling this difficult issue -- I know you've been looking > for a better solution. > > As I understand it, anyone will now need to add a public key to Phab > in order to upload patches. This (as you admit) will increase the > barriers to contri

RE: [commit: ghc] master: Remove unused DerivInst constructor for DerivStuff (f4384ef)

2016-08-30 Thread Simon Peyton Jones via ghc-devs
Ryan I just wanted to thank you for all the work you are doing on 'deriving' and generics. It's a very useful part of GHC, but it's sufficiently complicated that it's hard to dive in and make a quick fix. You are giving it sustained attention, and have become very familiar with the code, whic

Re: Last call for merge requests for 8.0.2

2016-08-30 Thread Ben Gamari
"Boespflug, Mathieu" writes: > Depends how you look at it I guess. It's arguably a fix to addModFinalizer, > which never really worked for the use case it was intended since it was > first introduced. This function was added by the author of > language-c-inline, who wanted things like > > cos ::

RE: Last call for merge requests for 8.0.2

2016-08-30 Thread Simon Peyton Jones via ghc-devs
If it merges ok, I’d be inclined to put this in. ·We know it’ll help someone (Mathieu and colleages). ·It (should) affect a new and as-yet little-used feature, so it’s unlikely to harm anyone.(Of course, ANY change can have unexpected consequences.) ·And you could r

hsc2hs fix

2016-08-30 Thread Richard Cook
Ben et al, I'm responding to your last call for merge requests ( https://mail.haskell.org/pipermail/ghc-devs/2016-August/012693.html). I would really like to get this fix to hsc2hs in if it all possible: https://phabricator.haskell.org/D2478 Thanks, Richard. _