Re: 8.5 build failure

2018-04-06 Thread Ryan Scott
I've just landed a commit of Ben's [1] which should fix this issue. Ryan S. - [1] Specifically, http://git.haskell.org/ghc.git/commit/54acfbbf64f5fcb108836412e9be0cfabf0d7801 ___ ghc-devs mailing list ghc-devs@haskell.org

Re: Why does the RTS run GC right before shutting down?

2018-04-06 Thread Ömer Sinan Ağacan
We already run all finalizers after exitScheduler: https://github.com/ghc/ghc/blob/master/rts/RtsStartup.c#L382-L388 so no need to run GC for that. Ömer 2018-04-06 17:06 GMT+03:00 Edward Z. Yang : > I believe it's so that we can run finalizers before shutdown. > > Excerpts from

Re: Why does the RTS run GC right before shutting down?

2018-04-06 Thread Edward Z. Yang
I believe it's so that we can run finalizers before shutdown. Excerpts from Ömer Sinan Ağacan's message of 2018-04-06 16:49:41 +0300: > Hi, > > I'm wondering why we run GC in this line: > > https://github.com/ghc/ghc/blob/master/rts/Schedule.c#L2670 > > I went back in commit history using git

Why does the RTS run GC right before shutting down?

2018-04-06 Thread Ömer Sinan Ağacan
Hi, I'm wondering why we run GC in this line: https://github.com/ghc/ghc/blob/master/rts/Schedule.c#L2670 I went back in commit history using git blame and found the commit that introduced that line (5638488ba28), but it didn't help. Does anyone know why we need that line? Thanks, Ömer