Re: [core libraries] Re: Add taggedTrace to Debug.Trace

2018-06-11 Thread Evan Laforge
I agree that tags are necessary, and in fact I recently ported my internal debug library to cabal because now that I'm doing more stuff with cabal I find life too difficult without my accustomed debug library. For reference, it is this, but nothing fancy:

Re: Typechecker doesn't preserve HsPar in renamed source.

2018-06-11 Thread Richard Eisenberg
Great -- and glad to see this getting appropriate attention over there. Richard > On Jun 11, 2018, at 11:51 PM, Zubin Duggal wrote: > > At the time I hadn't modified tcSeq and tcTagToEnum to take HsArgPars into > account. I have now done that, and also added a test case. > > I've also

Re: Typechecker doesn't preserve HsPar in renamed source.

2018-06-11 Thread Zubin Duggal
At the time I hadn't modified tcSeq and tcTagToEnum to take HsArgPars into account. I have now done that, and also added a test case. I've also submitted the fix to Phab, over here: https://phabricator.haskell.org/D4822 On 12 June 2018 at 09:04, Richard Eisenberg wrote: > This looks pretty

Re: Typechecker doesn't preserve HsPar in renamed source.

2018-06-11 Thread Richard Eisenberg
This looks pretty good to me. What's "in progress" about it? I would want to see a comment on the declaration for HsArgPar with an example, and a test case. Thanks! Richard > On Jun 7, 2018, at 6:38 AM, Zubin Duggal wrote: > > Hello all, > > The typechecker doesn't preserve parenthesis that

Re: [GHC] #15147: Type checker plugin receives Wanteds that are not completely unflattened

2018-06-11 Thread Nicolas Frisby
Whoops, I replied via email instead of commenting on the ticket. I've done so now. Sorry for the mailing list noise. On Mon, Jun 11, 2018, 08:21 Nicolas Frisby wrote: > That way of saying it clarifies the expectations for me. And doesn't seem > too burdensome for the plugin author. > > Thus I

Re: [core libraries] Re: Add taggedTrace to Debug.Trace

2018-06-11 Thread Yuji Yamamoto
Can anyone give me more feedback? I'm interested especially in my last reply. 2018年6月8日(金) 9:19 Yuji Yamamoto : > Almost any formatting will do. At least I never care. > I assume those APIs would be used for very ad-hoc use (like the other APIs > in Debug.Trace). > And debug codes put by such

Re: [GHC] #15147: Type checker plugin receives Wanteds that are not completely unflattened

2018-06-11 Thread Nicolas Frisby
That way of saying it clarifies the expectations for me. And doesn't seem too burdensome for the plugin author. Thus I think this ticket could be resolved by updating the documentation. (Though I still would like for a plugin to be able to request the flattened Wanteds. Separate ticket?) In