Christopher Done writes:
> Hey,
>
> Quick question: Does GHC have an upper limit on the length of binding names?
>
IIRC parser does not impose such a limit.
Cheers,
- Ben
signature.asc
Description: PGP signature
___
ghc-devs mailing list
ghc-devs@ha
definitely you'd have a bad day if you used up the heap :)
On Mon, Jan 14, 2019 at 7:23 PM Christopher Done
wrote:
> Hey,
>
> Quick question: Does GHC have an upper limit on the length of binding
> names?
>
> Cheers!
> ___
> ghc-devs mailing list
> ghc
Hey,
Quick question: Does GHC have an upper limit on the length of binding names?
Cheers!
___
ghc-devs mailing list
ghc-devs@haskell.org
http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs
Richard, what you propose totally makes sense to me.
Simon, Sylvain, indeed, when I click "toggle comments for this file"
in the first patch, I can see not only an avatar, but the whole comment.
However, this is only one comment, in both diffs, out of many,
which adds to the confusion. May it be c
Thanks. But none of the pictures arrived, so I can’t interpret what you say.
I think I did see Richards face here and there (and mine), if that’s want
avatars means. Hovering showed a snippet of a comment; but clicking did nothing.
I’m also terribly reluctant to scroll through thousands of line
I confirm that I see "Unresolve discussion" buttons in the "Discussion" page,
after "Toggle Discussion" is clicked.
Perhaps we have this working convention: the dev that starts the discussion is
expected to resolve it. I doubt GL can enforce that convention, but we can just
agree to it all. So,
On Mon, Jan 14, 2019 at 10:28 AM Simon Peyton Jones via ghc-devs <
ghc-devs@haskell.org> wrote:
>
> I suppose we could issue guidance NEVER to resolve a discussion, but that
seems like the wrong conclusion.
It seems gitlab's "resolve discussion" action is supposed to mean
"I think nobody needs to
> Yes, in the discussion tab I can. But of course that is out of context; you
> just get a little (non-expandable) snippet.
I lack the gitlab experience to push this any further, but I guess
an "unresolve discussion" button/checkbox would at least be
a stop-gap measure. I couldn't see such a but
| (without the 'diff' at the end) you can see the collapsed discussion items?
Yes, in the discussion tab I can. But of course that is out of context; you
just get a little (non-expandable) snippet.
Simon
| -Original Message-
| From: Mikolaj Konarski
| Sent: 14 January 2019 10:30
|
> Looking here
> https://gitlab.haskell.org/ghc/ghc/merge_requests/116//diffs
> I see literally NO discussions with a "toggle discussion" button. Indeed if
> I search for "toggle" I get no hits.
Oh, I see, you are right with respect to the link you cited now.
None of the buttons help, just as yo
Looking here
https://gitlab.haskell.org/ghc/ghc/merge_requests/116//diffs
I see literally NO discussions with a "toggle discussion" button. Indeed if I
search for "toggle" I get no hits.
When I initially clicked on "changes", the diff for TcHsType was initially
collapsed; I had to click on "Cli
> Either way, I can’t see any comments whatsoever! It says 5/5 discussions
> resolved, but I can’t actually see them. There is not “toggle discussion”
> button anywhere.
Hello Simon,
Just below "5/5 discussions resolved" I can see 5 discussions
with “toggle discussion” link to the right of ea
Devs
I’m at a loss for how to review GitLab changes. Richard sent me the message
below. So I follow the link to “View on GitLab”, or I manually edit the URL to
plain
https://gitlab.haskell.org/ghc/ghc/merge_requests/116
Either way, I can’t see any comments whatsoever! It says 5/5 discussions
13 matches
Mail list logo
