Re: [GitLab] Introducing Marge-bot

2019-01-26 Thread Phyx
> I also don't think one should be allowed to approve their own > PR. If it is trivial enough to justify a self-accept then someone else > should also be able to trivially accept it. I disagree whole heartedly, as someone who's had to wait weeks for trivial patches to get reviews no thanks. We sho

Re: [GitLab] Introducing Marge-bot

2019-01-26 Thread Ben Gamari
Phyx writes: >> I also don't think one should be allowed to approve their own >> PR. If it is trivial enough to justify a self-accept then someone else >> should also be able to trivially accept it. > > I disagree whole heartedly, as someone who's had to wait weeks for trivial > patches to get re

Purpose of the CODEOWNERS file

2019-01-26 Thread Matthew Pickering
There have been a flurry of MRs to add ownership to the CODEOWNERS file but it's not clear to me what this file does. It links to this page: https://docs.gitlab.com/ee/user/project/code_owners.html Which explains the syntax quite thoroughly but doesn't as far as I can see explain how this informa

Re: Purpose of the CODEOWNERS file

2019-01-26 Thread Ben Gamari
Matthew Pickering writes: > There have been a flurry of MRs to add ownership to the CODEOWNERS > file but it's not clear to me what this file does. > > It links to this page: > https://docs.gitlab.com/ee/user/project/code_owners.html > > Which explains the syntax quite thoroughly but doesn't as