Error messages

Hi all, Although it was many years ago I did spend soem time working on GHC and I do know what a thankless task it is. I made a compliant about GHC error messages on an internal Slack channel and Mortiz encouraged me to repeat it here. I am incredibly happy about the quality of error messges for

Re: HEAD doesn't build. Totally stalled.

Well, we actually *do* test for __SSP__ in HEAD: https://github.com/ghc/ghc/blob/master/rts/RtsSymbols.c#L1170 Which currently lists: #if !defined(mingw32_HOST_OS) && !defined(DYNAMIC) && (defined(_FORTIFY_SOURCE) || defined(__SSP__)) But this seems to still be ill conceived. And while Simon is t

Re: HEAD doesn't build. Totally stalled.

But, where do you actually check for __SSP__ The guard just checks for not windows and not dynamic https://github.com/ghc/ghc/commit/686e72253aed3880268dd6858eadd8c320f09e97#diff-03f5bc5a50fd8ae13e902782c4392c38R1157 shouldn't it just be checking for defined(__SSP__) instead? This check is curren

RE: HEAD doesn't build. Totally stalled.

Indeed – but it’s up to Moritz. I don’t want to back out the patch myself, in case that messes up what he’s doing. He’ll best placed to decide the least disruptive way forward S From: Mathieu Boespflug Sent: 16 July 2020 15:50 To: Simon Peyton Jones Cc: ghc-devs@haskell.org; Moritz Angerman

RE: HEAD doesn't build. Totally stalled.

Perhaps back out the offending patch from master in the meantime? On Thu, Jul 16, 2020 at 16:47:03, Simon Peyton Jones < ghc-devs@haskell.org > wrote: > > > > I could carry out experiments for you … > > > > > Regardless, some stop-gap fix would be helpuf. > > > > > > > > > > *Fro

RE: HEAD doesn't build. Totally stalled.

I could carry out experiments for you … Regardless, some stop-gap fix would be helpuf. From: Moritz Angermann Sent: 16 July 2020 15:45 To: Ben Gamari ; Simon Peyton Jones Cc: ghc-devs@haskell.org Subject: Re: HEAD doesn't build. Totally stalled. I’ve tried to reproduce this and it turns out, I

Re: HEAD doesn't build. Totally stalled.

I’ve tried to reproduce this and it turns out, I fail to. You are somehow building the rts either with _FORTYFY_SOURCE or __SSP__, but then your linker ends up not passing -lssp or the equivalent for your tool chain. At this point I’m tempted to add an additional ARM arch guard. While that would b

RE: HEAD doesn't build. Totally stalled.

Moritz How’s it going getting this patch committed? It’s painful manually applying a fix, but then NOT committing that to master by mistake Thanks s From: Moritz Angermann Sent: 14 July 2020 12:14 To: Simon Peyton Jones Cc: ghc-devs@haskell.org Subject: Re: HEAD doesn't build. Totally stalled.