Re: On CI

2021-02-21 Thread John Ericson
I'm not opposed to some effort going into this, but I would strongly opposite putting all our effort there. Incremental CI can cut multiple hours to < mere minutes, especially with the test suite being embarrassingly parallel. There simply no way optimizations to the compiler independent from

Re: Changes to performance testing?

2021-02-21 Thread Richard Eisenberg
> On Feb 21, 2021, at 11:24 AM, Ben Gamari wrote: > > To mitigate this I would suggest that we allow performance test failures > in marge-bot pipelines. A slightly weaker variant of this idea would > instead only allow performance *improvements*. I suspect the latter > would get most of the

Changes to performance testing?

2021-02-21 Thread Ben Gamari
Hi all, Recently our performance tests have been causing quite some pain. One reason for this is due to our new Darwin runners (see #19025), which (surprisingly) differ significantly in their performance characteristics (perhaps due to running Big Sur or using native tools provided by nix?).