[GitLab] Introducing Marge-bot

2019-01-22 Thread Ben Gamari
Hi everyone, As you might have noticed there is a new face on GitLab: Meet @marge-bot. Marge will be helping us with the pain of merging merge requests: Currently the typical workflow to merge an accepted MR involves the following: 1. Rebase the MR on top of the current `master` branch 2. Clic

Re: [GitLab] Introducing Marge-bot

2019-01-23 Thread Matthew Pickering
It seems that in order for marge-bot to work best we need to tighten up our policy towards merging so that it is only Marge who performs the merges. I think Marge gets confused if people push to master under her feet which means rebasing again and duplicating work. Can we disable the "Merge when p

Re: [GitLab] Introducing Marge-bot

2019-01-26 Thread Phyx
> I also don't think one should be allowed to approve their own > PR. If it is trivial enough to justify a self-accept then someone else > should also be able to trivially accept it. I disagree whole heartedly, as someone who's had to wait weeks for trivial patches to get reviews no thanks. We sho

Re: [GitLab] Introducing Marge-bot

2019-01-26 Thread Ben Gamari
Phyx writes: >> I also don't think one should be allowed to approve their own >> PR. If it is trivial enough to justify a self-accept then someone else >> should also be able to trivially accept it. > > I disagree whole heartedly, as someone who's had to wait weeks for trivial > patches to get re

RE: [GitLab] Introducing Marge-bot

2019-01-28 Thread Simon Peyton Jones via ghc-devs
CI validatation check. Simon From: ghc-devs On Behalf Of Phyx Sent: 26 January 2019 19:43 To: Matthew Pickering Cc: GHC developers Subject: Re: [GitLab] Introducing Marge-bot > I also don't think one should be allowed to approve their own > PR. If it is trivial enough to justify a