Re: [commit: ghc] master: comments only (9894f6a)

2015-01-20 Thread Simon Marlow
No, it checks for and skips over complete zero words, not just trailing zeroes. The bitmaps are really that sparse sometimes. Like hundreds of zero words with a few non-zero bits at either end. The change I made improved perf enough that this isn't a blocking issue for me any more, and I

Re: [commit: ghc] master: comments only (9894f6a)

2015-01-20 Thread Gabor Greif
On 1/20/15, Simon Marlow marlo...@gmail.com wrote: No, it checks for and skips over complete zero words, not just trailing zeroes. Sure, I mean the for-loops after your if-condition, in lines 291 and 304

Re: [commit: ghc] master: comments only (9894f6a)

2015-01-20 Thread Herbert Valerio Riedel
Hello Gabor, Fyi, Alex (cc'ed) already spent some brain-cycles on that, but it's not clear yet if it's worth optimising: https://gist.github.com/axman6/46edae58cc4e8242bdac Cheers, hvr On 2015-01-20 at 14:45:19 +0100, Gabor Greif wrote: Hi Simon, JFTR, you seem to be after the trailing