Re: CI: Choice of base commit for perf comparisons

2021-12-22 Thread Joachim Breitner
Thanks! I like it when my feature suggestions are implemented even before I voice them ;-) 22.12.2021 14:13:24 Richard Eisenberg : > It seems to be that this thought is in the air right now. This was done just > a few days ago: https://gitlab.haskell.org/ghc/ghc/-/merge_requests/7184 > > https

Re: CI: Choice of base commit for perf comparisons

2021-12-22 Thread Richard Eisenberg
It seems to be that this thought is in the air right now. This was done just a few days ago: https://gitlab.haskell.org/ghc/ghc/-/merge_requests/7184 https://gitlab.haskell.org/ghc/ghc/-/merge_requests/7231 also looks relevant. Richard > On Dec 22, 2021, at 7:19 AM, Joachim Breitner > wrote:

CI: Choice of base commit for perf comparisons

2021-12-22 Thread Joachim Breitner
Hi, the new (or “new”?) handling of perf numbers, where CI just magically records and compares them, without us having to manually edit the `all.T` files, is a big improvement, thanks! However, I found the choice of the base commit to compare against unhelpful. Assume master is at commit M, and I