GHC Exactprint merge process

2021-03-06 Thread Alan & Kim Zimmerman
I have been running a branch in !2418[1] for just over a year to migrate the ghc-exactprint functionality directly into the GHC AST[2], and I am now satisfied that it is able to provide all the same functionality as the original. This is one of the features intended for the impending 9.2.1 release

Re: GHC Exactprint merge process

2021-03-06 Thread Ben Gamari
"Alan & Kim Zimmerman" writes: > I have been running a branch in !2418[1] for just over a year to migrate > the ghc-exactprint functionality directly into the GHC AST[2], and I am now > satisfied that it is able to provide all the same functionality as the > original. > > This is one of the featu

Re: GHC Exactprint merge process

2021-03-11 Thread Richard Eisenberg
I've started a review, but sent along what I had when dinner was ready. Hopefully more later, but don't wait up for me! Incidentally: this is a monstrous patch, and so there is a strong incentive just to get on with it without resolving all these quibbles. I won't stand in your way on that fron

Re: GHC Exactprint merge process

2021-03-12 Thread Richard Eisenberg
After a consult with Simon, I've updated the relevant wiki page at https://gitlab.haskell.org/ghc/ghc/-/wikis/api-annotations with a sketch of a design description for this new feature, along with lots of questions. Both Simon and I agree that it may be more sensible to merge first and ask quest

Re: GHC Exactprint merge process

2021-03-12 Thread Alan & Kim Zimmerman
Thanks Richard This MR is a huge change, and hard to digest. But it is also a step function, in that we cannot have the old way of using API Annotations for exact printing and the new way at the same time. So I have focused on making sure that it can actually do what I believe is required, whi