Re: Gitlab pain

2019-01-19 Thread Gabor Greif
I have just tried putting following URL into the discussion tab's URL bar javascript: $(".discussion-toggle-button:has(i.fa-chevron-down)").click() and it seems to work. Cheers, Gabor On 1/4/19, Artem Pelenitsyn wrote: > It seems you'd want the "Toggle All" button. There is an issue

Re: Gitlab pain

2019-01-04 Thread Ben Gamari
On January 4, 2019 2:17:45 PM EST, Artem Pelenitsyn wrote: >It seems you'd want the "Toggle All" button. There is an issue for >that: > >https://gitlab.com/gitlab-org/gitlab-ce/issues/19149 > Precisely. Thank you for finding this. Cheers, - Ben -- Sent from my Android device with K-9

Re: Gitlab pain

2019-01-04 Thread Artem Pelenitsyn
It seems you'd want the "Toggle All" button. There is an issue for that: https://gitlab.com/gitlab-org/gitlab-ce/issues/19149 There is even a beautiful workaround given there with typing the following command in the JavaScript console in a browser:

Re: Gitlab pain

2019-01-04 Thread Ben Gamari
Quite right. I will bring this up with upstream. On January 4, 2019 1:04:43 PM EST, Brandon Allbery wrote: >On Fri, Jan 4, 2019 at 1:02 PM Ben Gamari wrote: > >> As mentioned by others, discussions that have been marked as >"resolved" >> are collapsed by default. If you search for the text

RE: Gitlab pain

2019-01-04 Thread Ben Gamari
Simon Peyton Jones via ghc-devs writes: > | The Discussion tab is ground truth for comments in that you won't miss any > | if you look through it, but it gets cluttered. > > Apparently not. Check out > https://gitlab.haskell.org/ghc/ghc/merge_requests/10 > and search for "Another module

RE: Gitlab pain

2019-01-04 Thread Simon Peyton Jones via ghc-devs
definitely in a comment. Maybe I'm missing something. Simon | -Original Message- | From: Evan Laforge | Sent: 04 January 2019 17:13 | To: Richard Eisenberg | Cc: Simon Peyton Jones ; ghc-devs | Subject: Re: Gitlab pain | | The diff in | https://nam06.safelinks.protection.outlook.com/

Re: Gitlab pain

2019-01-04 Thread Evan Laforge
The diff in https://gitlab.haskell.org/ghc/ghc/merge_requests/10/diffs is the ground truth for the source code. However, it's not ground truth for comments. You only get to see the ones attached to the revisions selected in "Changes between x and y", which means they tend to get lost. The

RE: Gitlab pain

2019-01-04 Thread Simon Peyton Jones via ghc-devs
Eisenberg Sent: 04 January 2019 16:26 To: Simon Peyton Jones Cc: ghc-devs Subject: Re: Gitlab pain GitLab groups posts on lines in MRs as "discussions". A discussion can be *resolved*. When it is resolved, the discussion is collapsed by default when you view the MR. The particular comm

Re: Gitlab pain

2019-01-04 Thread Richard Eisenberg
GitLab groups posts on lines in MRs as "discussions". A discussion can be *resolved*. When it is resolved, the discussion is collapsed by default when you view the MR. The particular comment you're seeking can be found on the MR if you open the discussion you started at 10:04am this morning

Gitlab pain

2019-01-04 Thread Simon Peyton Jones via ghc-devs
I'm getting lost in a maze of twisty little passages, all alike. I'm looking at https://gitlab.haskell.org/ghc/ghc/merge_requests/10#note_1877 and https://gitlab.haskell.org/ghc/ghc/merge_requests/10 But the note in the former starting "Another module should reference the symbol..." doesn't show