Re: Marge has been stabilised

2019-02-13 Thread Matthew Pickering
something else in the UI? > > S > > | -Original Message- > | From: Matthew Pickering > | Sent: 13 February 2019 10:10 > | To: Simon Peyton Jones > | Cc: Richard Eisenberg ; GHC developers | d...@haskell.org> > | Subject: Re: Marge has been stabilised > | > | As

RE: Marge has been stabilised

2019-02-13 Thread Simon Peyton Jones via ghc-devs
le string itself? Or do you do something else in the UI? S | -Original Message- | From: Matthew Pickering | Sent: 13 February 2019 10:10 | To: Simon Peyton Jones | Cc: Richard Eisenberg ; GHC developers | Subject: Re: Marge has been stabilised | | As far as I can work out the

Re: Marge has been stabilised

2019-02-13 Thread Matthew Pickering
> > > Simon > > > > > > | -----Original Message- > > | From: ghc-devs On Behalf Of Matthew > > | Pickering > > | Sent: 12 February 2019 16:29 > > | To: Richard Eisenberg > > | Cc: GHC developers > > | Subject: Re: Marge has b

Re: Marge has been stabilised

2019-02-12 Thread Matthew Pickering
Yes, on a quiet day she will idly wait for the opportunity to merge two MRs rather than try and merge just one. I don't think this is a bad default as her CI cycle has proved to be quite long so only 2-3 batches happen per day at most. Matt On Tue, Feb 12, 2019 at 6:36 PM Alan & Kim Zimmerman

Re: Marge has been stabilised

2019-02-12 Thread Alan & Kim Zimmerman
> Every 30 minutes whilst idle she will try to find new MRs to batch > together. If she finds at least two MRs to batch together then she > creates a batch as a new merge request. A batch is the series of MRs > rebased on top of each other from oldest to newest. Does this mean that on a quiet

Re: Marge has been stabilised

2019-02-12 Thread Matthew Pickering
Yes there are two others I use frequently. /approve - Approves a Merge request /assign - Assign a user and I imagine I will use /label and /relabel frequently when we have labels. It's also useful to know that the ! autocomplete for merge requests can be filtered by name of MR. The user

Re: Marge has been stabilised

2019-02-12 Thread Richard Eisenberg
> On Feb 12, 2019, at 10:51 AM, Matthew Pickering > wrote: > > This can be quickly toggled on/off by typing the /wip quick command in > a comment. This is an interesting aside. I understand this to mean: If I make a comment (the same place that I would write a comment for humans) that

Re: Marge has been stabilised

2019-02-12 Thread Matthew Pickering
WIP merge requests have "WIP:" at the front of the title. I have been marking MRs as WIP is they are not ready to merge to try to keep track of things that need to be added to the merge queue or not. This can be quickly toggled on/off by typing the /wip quick command in a comment. Cheers, Matt

Marge has been stabilised

2019-02-12 Thread Matthew Pickering
Hi all, I think I have finally managed to stablise the merge bot (Marge). If you have a patch ready to merge then 1. Make sure that CI shows as passing 2. Make sure it has been approved by at least one person 3. Make sure it is not marked as WIP Once these three conditions are met, assign the