Re: Note [Api annotations]

2016-07-20 Thread Alan & Kim Zimmerman
Hopefully at a future date they will be a part of the AST itself, so this will be clearer. In reality, looking at Parser.y is not enough, as there are some workings in RdrHsSyn.hs too, and the process of attachment in Parser.y is sometimes quite complex. Basically the best reference is indeed

Re: Note [Api annotations]

2016-07-20 Thread Matthew Pickering
On Wed, Jul 20, 2016 at 12:22 PM, Ben Gamari wrote: > Matthew Pickering writes: > >> These comments are meant to indicate which annotations each AST >> fragment has. However, they are rarely kept up to date and ultimately >> not that useful. If

Re: Note [Api annotations]

2016-07-20 Thread Ben Gamari
Matthew Pickering writes: > These comments are meant to indicate which annotations each AST > fragment has. However, they are rarely kept up to date and ultimately > not that useful. If someone wants to > know then it is easier to look at the `Annotate` module in >

Re: Note [Api annotations]

2016-07-20 Thread Matthew Pickering
piAnnotation.AnnClose' > > -- For details on above see note [Api annotations] in ApiAnnotation > > in some files, but Note [Api annotations] in compiler/parser/ApiAnnotation.hs > doesn't say anything about those comments. Can someone update the note

Note [Api annotations]

2016-07-20 Thread Ömer Sinan Ağacan
I see some weird comments like -- - 'ApiAnnotation.AnnKeywordId' : 'ApiAnnotation.AnnOpen', -- 'ApiAnnotation.AnnVbar','ApiAnnotation.AnnComma', -- 'ApiAnnotation.AnnClose' -- For details on above see note [Api annotations] in ApiAnnotation in some