Hello all,
Recently, while doing server maintenance, several of the
administrators for Haskell.org set up an instance of Phabricator[1],
located at https://phabricator.haskell.org
For those who aren't aware, Phabricator (or "Phab") is a suite of
tools for software development. Think of it like a
ustin
| Seipp
| Sent: 06 June 2014 05:06
| To: ghc-devs@haskell.org
| Subject: RFC: Phabricator for patches and code review
|
| Hello all,
|
| Recently, while doing server maintenance, several of the administrators
| for Haskell.org set up an instance of Phabricator[1], located at
| https://phabricator.haske
PS I couldn't get past the login box at https://phabricator.haskell.org/D4
| -Original Message-
| From: ghc-devs [mailto:ghc-devs-boun...@haskell.org] On Behalf Of Austin
| Seipp
| Sent: 06 June 2014 05:06
| To: ghc-devs@haskell.org
| Subject: RFC: Phabricator for patches and code r
adcrumbs, at least.
> Simon
>
> | -Original Message-
> | From: ghc-devs [mailto:ghc-devs-boun...@haskell.org] On Behalf Of Austin
> | Seipp
> | Sent: 06 June 2014 05:06
> | To: ghc-devs@haskell.org
> | Subject: RFC: Phabricator for patches and code review
> |
> |
> | To: ghc-devs@haskell.org
> | Subject: RFC: Phabricator for patches and code review
> |
> | Hello all,
> |
> | Recently, while doing server maintenance, several of the administrators
> | for Haskell.org set up an instance of Phabricator[1], located at
> | https://phabri
l Message-
> | From: ghc-devs [mailto:ghc-devs-boun...@haskell.org] On Behalf Of Austin
> | Seipp
> | Sent: 06 June 2014 05:06
> | To: ghc-devs@haskell.org
> | Subject: RFC: Phabricator for patches and code review
> |
> | Hello all,
> |
> | Recently, while doi
ortant should appear in a Note in the source code; even the
commit messages are invisible until you really start digging.
Simon
| -Original Message-
| From: ghc-devs [mailto:ghc-devs-boun...@haskell.org] On Behalf Of Austin
| Seipp
| Sent: 06 June 2014 05:06
| To: ghc-devs@haskell.org
n the final patch.
>> Anything that's important should appear in a Note in the source code; even
>> the commit messages are invisible until you really start digging.
>>
>> Simon
>>
>> | -Original Message-
>> | From: ghc-devs [mailto:ghc-devs
sed out about losing the review trail of a patch. Much of
>> it will be commenting on stuff that no longer appears in the final patch.
>> Anything that's important should appear in a Note in the source code; even
>> the commit messages are invisible until you really star
sure it works from Windows equally well.
>>>
>>> I'm not too stressed out about losing the review trail of a patch. Much
>>> of it will be commenting on stuff that no longer appears in the final patch.
>>> Anything that's important should appear in a Note
l of a patch. Much of it
will be commenting on stuff that no longer appears in the final patch.
Anything that's important should appear in a Note in the source code; even the
commit messages are invisible until you really start digging.
Simon
| -Original Message-
| From: ghc-d
ng.
Simon
| -Original Message-
| From: ghc-devs [mailto:ghc-devs-boun...@haskell.org] On Behalf Of Austin
| Seipp
| Sent: 06 June 2014 05:06
| To: ghc-devs@haskell.org
| Subject: RFC: Phabricator for patches and code review
|
| Hello all,
|
| Recently, while doing server maintenance, severa
; >> around?
> >>
> >> Also before going too far I'd really like someone to document the
> >> workflow carefully, and make sure it works from Windows equally well.
> >>
> >> I'm not too stressed out about losing the review trail of a pa
he commit messages are invisible until you really start
digging.
Simon
| -----Original Message-
| From: ghc-devs [mailto:ghc-devs-boun...@haskell.org] On Behalf Of
| Austin Seipp
| Sent: 06 June 2014 05:06
| To: ghc-devs@haskell.org
| Subject: RFC: Phabricator for patches and code review
|
|
> You can use it, and a few of us have already been doing so. There isn't
> any Trac integration yet, but it works nicely for patch review.
Right. I was wondering about the inclusion of phabricator utilities in the GHC
tree - I believe
this was mentioned in the discussion.
> There's a short int
n't have a good work flow for creating, reviewing,
> >>>> modifying, and finally apply patches. I am no expert on these
> >>>> matters. If Phabricator would help with that I'm all for it. But
> >>>> perhaps there are other alternatives? O
ulate zillions of dead branches
> > >>>> which people forgot to delete. I think on github the branch is in a
> > >>>> different repo, belonging to the patch author.
> > >>>>
> > >>>> So we really don't hav
ke a branch, but there's a
>> > >>>> danger that over a decade we'll accumulate zillions of dead branches
>> > >>>> which people forgot to delete. I think on github the branch is in a
>> > >>>> different repo, belonging t
highly imperfect understanding) people can't submit pull
>>>>>>>> requests or use their code review mechanisms. Moreover, most people
>>>>>>>> don't have commit rights on the main GHC server, so if someone wants
>>>>>&
gt;>>>>> system)? Let’s outsource the effort to GitHub.
> >>>>>>>
> >>>>>>> Manuel
> >>>>>>>
> >>>>>>> Simon Peyton Jones :
> >>>>>>>> At the moment GHC's
it works really well.
>>>>>>>
>>>>>>> What's more, github doesn't let you put animated gifs in code reviews.
>>>>>>> Need I say more?
>>>>>>>
>>>>>>> Cheers,
>>>>>
gt;>>>>> wouldn't cut it for doing a lot of code reviewing, whereas I spend
>> >>>>>> my
>> >>>>>> life inside Phabricator so I know it works really well.
>> >>>>>>
>> >>>>>> What's more,
-boun...@haskell.org] On Behalf Of Austin
| Seipp
| Sent: 24 June 2014 18:13
| To: Richard Eisenberg
| Cc: ghc-devs@haskell.org
| Subject: Re: Phabricator for patches and code review
|
| Richard,
|
| Thanks, these are all actually really excellent questions.
|
| > 1) I'm just setting things
meone wants
>>>>>>>> to offer a patch they can really only do so in textual
form attached
>>>>>>>> to Trac. People with commit rights can make a branch, but
there's a
>>>>>>>> danger that over a d
while i'm a novice at using ANY code review tools, having some persistent
tooling for patch reviews would be really great! theres a lot of good
feedback that otherwise only exists in an email somewhere!
On Fri, Jun 6, 2014 at 12:05 AM, Austin Seipp wrote:
> Hello all,
>
> Recently, while doing
2014-06-06 7:05 GMT+03:00 Austin Seipp :
> 2) Phabricator in particular makes it very easy to submit patches for
> review. To submit a patch, I just run the command 'arc diff' and it
> Does The Right Thing. It also makes it easy to ensure people are
> *alerted* when a patch might be relevant to th
tl;dir I strongly support this, but for code review only, and only if we
can integrate it well with Trac.
Phabricator is what we use internally at Facebook, and it's a really
good code review tool (better than github, IMO). For one thing, you
only get one email for a complete review, rather t
I haven't looked deeply into Trac integration yet, but I believe this
should generally be possible. I'll probably pester the developers
about it later today. I'm glad people seem receptive to it.
I don't think Arcanist will be a barrier, actually. Here's what I
propose: we add arcanist and libphut
No, at the moment Phabricator is not integrated with any testing
functionality. It could be, but that would be a bit of work I think to
integrate with GHC's ./validate process. It would be nice to have
long-term, however, but I don't think it's necessary right now - I run
./validate before every pu
Piggybacking a bit on Ömer's point:
It is often the case that something flies by that I can fix in a few moments
(for example, #9163) but that I have to defer until I have enough time for a
GHC hacking session. Making even a tiny patch requires that I'm up-to-date,
that my unchanged tree compil
Richard, I think Phabricator would suit this just fine.
Here's (roughly) how Phabricator will work from a GHC hackers point of view.
1) I have a thing I want. Make a branch, hack hack hack away.
$ git branch new-thing
$ git checkout new-thing
$ emacs
$ git commit -a -m "Add minor new th
I assume if the decission is made to use this, the read-only view won't
require any login or registration?
Nicolas
On Jun 6, 2014 6:05 AM, "Austin Seipp" wrote:
> Hello all,
>
> Recently, while doing server maintenance, several of the
> administrators for Haskell.org set up an instance of Phabri
32 matches
Mail list logo
