I don't mind too much either way what happens here as I have no
outstanding changes.
However, I generally agree with the Simons. We've been slowly removing
tabs over time and a little ugliness doesn't hurt for now. I also like
that de-tabbing for me has been a big motivation to not simply de-tab,
I like Alexander's idea, but there's a subtle problem with it: Any sizeable
change to one file requires (at least) small changes in several other files.
Say X.hs has tabs. If I make a one-line change to X.hs, and you're in the
middle of massive changes to X.hs, and I detab X.hs in the course of
Then it's even easier. Update the hook to reject all tabs in source code
files, wait 6 months, and start detabbing the remaining files. Then the
probability of conflict should be pretty low.
Alexander
On Fri, Jan 18, 2013 at 1:46 PM, Jan Stolarek wrote:
> Dnia piątek, 18 stycznia 2013, Alexan
Dnia piątek, 18 stycznia 2013, Alexander Kjeldaas napisał:
> Well if this is true, then I think you could solve this simply by looking
> for this in a git commit hook or some other hook.
> http://stackoverflow.com/questions/3985463/prevent-pushes-to-git-containing
>-tabs-in-certain-files-e-g-cpp-h-
On Jan 18, 2013 10:17 AM, "Jan Stolarek" wrote:
> > I don't think it's worth the bother either: conflicts are a pain and
> > slow down development, whereas tabs don't. (...) there certainly are a
> > few active branches with large-scale changes.
> That's another good point.
>
> I looked through
> I don't think it's worth the bother either: conflicts are a pain and
> slow down development, whereas tabs don't. (...) there certainly are a
> few active branches with large-scale changes.
That's another good point.
I looked through the git history and it seems there are actually few tabbed
fi
I don't know whether the files have been "stable" or not, but I'm working on
some pretty massive changes to a handful of files in order to support promotion
of GADTs, among other fun things. So, if I may ask, please stay away from
detabbing the following:
TypeRep
Type
Coercion
OptCoercion
Unify
Dnia czwartek, 17 stycznia 2013, Simon Peyton-Jones napisał:
> But if you find files that are stable -- have not been modified for some
> months -- then yes you could detab them.
This seems to be a good heuristic.
> I'm unsure it's worth the bother
Cleaner code is worth the bother :) Especially t
On 17/01/13 14:06, Simon Peyton-Jones wrote:
Hmm. Precisely because it causes un-forced conflicts, our policy has been:
de-tab when you are modifying a file anyway
But if you find files that are stable -- have not been modified for some months
-- then yes you could detab them. Perhaps o
Hmm. Precisely because it causes un-forced conflicts, our policy has been:
de-tab when you are modifying a file anyway
But if you find files that are stable -- have not been modified for some months
-- then yes you could detab them. Perhaps one directory at a time?
I'm unsure it's wor
10 matches
Mail list logo
