Re: Typechecker doesn't preserve HsPar in renamed source.

2018-06-11 Thread Richard Eisenberg
Great -- and glad to see this getting appropriate attention over there. Richard > On Jun 11, 2018, at 11:51 PM, Zubin Duggal wrote: > > At the time I hadn't modified tcSeq and tcTagToEnum to take HsArgPars into > account. I have now done that, and also added a test case. > > I've also submitt

Re: Typechecker doesn't preserve HsPar in renamed source.

2018-06-11 Thread Zubin Duggal
At the time I hadn't modified tcSeq and tcTagToEnum to take HsArgPars into account. I have now done that, and also added a test case. I've also submitted the fix to Phab, over here: https://phabricator.haskell.org/D4822 On 12 June 2018 at 09:04, Richard Eisenberg wrote: > This looks pretty good

Re: Typechecker doesn't preserve HsPar in renamed source.

2018-06-11 Thread Richard Eisenberg
This looks pretty good to me. What's "in progress" about it? I would want to see a comment on the declaration for HsArgPar with an example, and a test case. Thanks! Richard > On Jun 7, 2018, at 6:38 AM, Zubin Duggal wrote: > > Hello all, > > The typechecker doesn't preserve parenthesis that

Typechecker doesn't preserve HsPar in renamed source.

2018-06-07 Thread Zubin Duggal
Hello all, The typechecker doesn't preserve parenthesis that occur at the head of applications. This results in some weird SrcSpans in the TypecheckedSource For example, given code foo a b c = (bar a) b c The typechecker will emit an HsApp with head spanning over `bar a) b` and tail spanning o