Re: Validate on master broken.

2018-11-16 Thread Alp Mestanogullari
November 2018 21:41 | To: Andreas Klebinger | Cc: ghc-devs@haskell.org | Subject: Re: Validate on master broken. | | Thanks for noticing! | | I’m fixing this right now. The changes needed are really quite mundane… | | -Alec | | > On Nov 15, 2018, at 1:28 PM, Andreas Klebinger | wr

Re: Validate on master broken.

2018-11-16 Thread Ömer Sinan Ağacan
ent: 15 November 2018 21:41 > > | To: Andreas Klebinger > > | Cc: ghc-devs@haskell.org > > | Subject: Re: Validate on master broken. > > | > > | Thanks for noticing! > > | > > | I’m fixing this right now. The changes needed are really quite

Re: Validate on master broken.

2018-11-15 Thread Ömer Sinan Ağacan
t; | From: ghc-devs On Behalf Of Alec Theriault > | Sent: 15 November 2018 21:41 > | To: Andreas Klebinger > | Cc: ghc-devs@haskell.org > | Subject: Re: Validate on master broken. > | > | Thanks for noticing! > | > | I’m fixing this right now. The changes needed are really

RE: Validate on master broken.

2018-11-15 Thread Simon Peyton Jones via ghc-devs
Bother -- my fault. Sorry about that. I should have thought of Haddock. Thanks for fixing. Simon | -Original Message- | From: ghc-devs On Behalf Of Alec Theriault | Sent: 15 November 2018 21:41 | To: Andreas Klebinger | Cc: ghc-devs@haskell.org | Subject: Re: Validate on master

Re: Validate on master broken.

2018-11-15 Thread Alec Theriault
Thanks for noticing! I’m fixing this right now. The changes needed are really quite mundane… -Alec > On Nov 15, 2018, at 1:28 PM, Andreas Klebinger > wrote: > > Hello Devs, > > it seems Simons patch "Smarter HsType pretty-print for promoted datacons" > broke ./validate. > > > >> I

Validate on master broken.

2018-11-15 Thread Andreas Klebinger
Hello Devs, it seems Simons patch "Smarter HsType pretty-print for promoted datacons" broke ./validate. I discovered that there were two copies of the PromotionFlag type (a boolean, with helpfully named data cons), one in IfaceType and one in HsType. So I combined into one,