Re: mask in waitQSem

2014-11-25 Thread Simon Marlow
On 24/11/2014 11:12, Yuras Shumovich wrote: On Mon, 2014-11-24 at 10:09 +, Simon Marlow wrote: On 14/11/2014 21:23, Yuras Shumovich wrote: I was reviewing some exception handling code in base library, and I found this line:

Re: mask in waitQSem

2014-11-25 Thread Yuras Shumovich
On Tue, 2014-11-25 at 13:53 +, Simon Marlow wrote: On 24/11/2014 11:12, Yuras Shumovich wrote: On Mon, 2014-11-24 at 10:09 +, Simon Marlow wrote: On 14/11/2014 21:23, Yuras Shumovich wrote: I was reviewing some exception handling code in base library, and I found this line:

Re: mask in waitQSem

2014-11-25 Thread Simon Marlow
On 25/11/2014 14:03, Yuras Shumovich wrote: On Tue, 2014-11-25 at 13:53 +, Simon Marlow wrote: On 24/11/2014 11:12, Yuras Shumovich wrote: On Mon, 2014-11-24 at 10:09 +, Simon Marlow wrote: On 14/11/2014 21:23, Yuras Shumovich wrote: I was reviewing some exception handling code in

Re: mask in waitQSem

2014-11-24 Thread Simon Marlow
On 14/11/2014 21:23, Yuras Shumovich wrote: I was reviewing some exception handling code in base library, and I found this line: https://phabricator.haskell.org/diffusion/GHC/browse/master/libraries/base/Control/Concurrent/QSem.hs;165072b334ebb2ccbef38a963ac4d126f1e08c96$74 Here mask is used,

Re: mask in waitQSem

2014-11-24 Thread Simon Marlow
On 14/11/2014 21:30, Brandon Allbery wrote: On Fri, Nov 14, 2014 at 4:23 PM, Yuras Shumovich shumovi...@gmail.com mailto:shumovi...@gmail.com wrote: Here mask is used, but I looks completely useless for me. waitQSem itself should be called with async exceptions masked, otherwise there

Re: mask in waitQSem

2014-11-24 Thread Yuras Shumovich
On Mon, 2014-11-24 at 10:09 +, Simon Marlow wrote: On 14/11/2014 21:23, Yuras Shumovich wrote: I was reviewing some exception handling code in base library, and I found this line:

mask in waitQSem

2014-11-14 Thread Yuras Shumovich
Hello, I was reviewing some exception handling code in base library, and I found this line: https://phabricator.haskell.org/diffusion/GHC/browse/master/libraries/base/Control/Concurrent/QSem.hs;165072b334ebb2ccbef38a963ac4d126f1e08c96$74 Here mask is used, but I looks completely useless for me.

Re: mask in waitQSem

2014-11-14 Thread Brandon Allbery
On Fri, Nov 14, 2014 at 4:23 PM, Yuras Shumovich shumovi...@gmail.com wrote: Here mask is used, but I looks completely useless for me. waitQSem itself should be called with async exceptions masked, otherwise there is no way to prevent resource leak. Do anyone know why mask is used here? I

Re: mask in waitQSem

2014-11-14 Thread Yuras Shumovich
On Fri, 2014-11-14 at 16:30 -0500, Brandon Allbery wrote: On Fri, Nov 14, 2014 at 4:23 PM, Yuras Shumovich shumovi...@gmail.com wrote: Here mask is used, but I looks completely useless for me. waitQSem itself should be called with async exceptions masked, otherwise there is no way to