Re: [Gimp-developer] Scope of variables

2009-11-17 Thread Martin Nordholts
Nelson A. de Oliveira wrote: > Hi! > > Is it interesting to limit the scope of the variables to where they > are only used? Hi! Yes, but this is the kind of changes you'd do when you have commit access. It would be too much work to review a big inflow of these kinds of patches. Regards, Marti

Re: [Gimp-developer] Fixes for memory leaks

2009-11-17 Thread Martin Nordholts
Nelson A. de Oliveira wrote: > Hi! > > While giving a look at bug #595605 (from Gimp Bugzilla), I have > remembered about cppcheck. > I have created a patch available at > > http://people.debian.org/~naoliv/misc/gimp-mememleak.diff Hi! Please generate the patch as a commit according to these in

Re: [Gimp-developer] Scope of variables

2009-11-17 Thread Nelson A. de Oliveira
Hi again! On Wed, Nov 18, 2009 at 12:23 AM, Nelson A. de Oliveira wrote: > For example, i is not used inside only one if here in > app/core/gimpimage-convert.c (and thus has been moved to where it's > only necessary): I need to sleep. Read it as: "For example, i is used inside only one if here i

[Gimp-developer] Scope of variables

2009-11-17 Thread Nelson A. de Oliveira
Hi! Is it interesting to limit the scope of the variables to where they are only used? For example, i is not used inside only one if here in app/core/gimpimage-convert.c (and thus has been moved to where it's only necessary): --- app/core/gimpimage-convert.c.old2009-11-18 00:18:55.0 -

[Gimp-developer] Fixes for memory leaks

2009-11-17 Thread Nelson A. de Oliveira
Hi! While giving a look at bug #595605 (from Gimp Bugzilla), I have remembered about cppcheck. I have created a patch available at http://people.debian.org/~naoliv/misc/gimp-mememleak.diff fixing (I hope) some leakages inside the plug-ins dir. Can somebody review it, please? There are some erro

Re: [Gimp-developer] i18n in an external pack of scripts

2009-11-17 Thread Alexia Death
On Mon, Nov 16, 2009 at 11:14 PM, Sven Neumann wrote: > On Mon, 2009-11-16 at 23:54 +0300, Alexandre Prokoudine wrote: > >> 3. Somehow make GIMP understand that it has to load >> gimp20-my-pack-of-scripts.mo files. > > For a plug-in this is easy. The plug-in would have to make sure that it > calls