Re: [Gimp-developer] Displaying linear gamma images

2013-09-13 Thread Elle Stone
Hi Daniel, Thanks! for the input. I'm pondering your suggestions about the code and I'll check in with you and Mitch on IRC in the next couple of days. -- http://ninedegreesbelow.com Just because it's a standard, doesn't mean it's right. ___

Re: [Gimp-developer] Displaying linear gamma images

2013-09-12 Thread Elle Stone
I've made progress getting a linear gamma image to display without posterization in the shadows. I put up a temporary web page with the modified code and a picture: http://ninedegreesbelow.com/temp/convert-buffer-before-cairo.html The problem at this point is that the image won't display properly

Re: [Gimp-developer] Displaying linear gamma images

2013-09-12 Thread Jon Nordby
On 12 September 2013 16:08, Elle Stone l.elle.st...@gmail.com wrote: I've made progress getting a linear gamma image to display without posterization in the shadows. I put up a temporary web page with the modified code and a picture:

Re: [Gimp-developer] Displaying linear gamma images

2013-09-12 Thread Daniel Sabo
You should bug mitch or me IRC for faster responses :). Issues with this code: Don't modify the buffer you got from gimp_pickable_get_buffer (GIMP_PICKABLE (projection)), it's a live part of the projection. Adding the buffer to the iterator twice probably doesn't do what you want it to do.

Re: [Gimp-developer] Displaying linear gamma images

2013-09-12 Thread Elle Stone
On 9/12/13, Jon Nordby jono...@gmail.com wrote: On 12 September 2013 16:08, Elle Stone l.elle.st...@gmail.com wrote: The problem at this point is that the image won't display properly until something like doing a very small levels correction forces a screen redraw. After forcing a screen

Re: [Gimp-developer] Displaying linear gamma images (Was Re: Update on my Gimp color management coding efforts)

2013-09-11 Thread Jon Nordby
On 10 September 2013 17:15, Elle Stone l.elle.st...@gmail.com wrote: On 11/12/12, Elle Stone l.elle.st...@gmail.com wrote: On 11/10/12, Michael Natterer mi...@gimp.org wrote: On Sat, 2012-11-10 at 15:17 -0500, Elle Stone wrote: On 11/8/12, Jon Nordby jono...@gmail.com wrote: * Change the

Re: [Gimp-developer] Displaying linear gamma images

2013-09-11 Thread Elle Stone
Hmm, I managed to get past the problem of not linking to lcms2. The solution was to compile Gimp using MAKEOPTS=-j3 CFLAGS=-Wl,--no-as-needed LDFLAGS=-llcms2 ./autogen.sh . . . not that I know why that seems to have worked. On to the next step. -- http://ninedegreesbelow.com - articles on color

[Gimp-developer] Displaying linear gamma images (Was Re: Update on my Gimp color management coding efforts)

2013-09-10 Thread Elle Stone
On 11/12/12, Elle Stone l.elle.st...@gmail.com wrote: On 11/10/12, Michael Natterer mi...@gimp.org wrote: On Sat, 2012-11-10 at 15:17 -0500, Elle Stone wrote: On 11/8/12, Jon Nordby jono...@gmail.com wrote: * Change the lcms-based conversion (modules/display-filter-lcms.c) from being a

Re: [Gimp-developer] Displaying linear gamma images (Was Re: Update on my Gimp color management coding efforts)

2013-09-10 Thread Daniel Sabo
The conversion happens in app/display/gimpdisplayshell-render.c : gimp_display_shell_render() . Look for the gegl_buffer_get call that converts to babl_format (cairo-ARGB32). It's more complicated that just that because the display filters all expect sRGB u8 data still, but I suspect the best