Re: Review Request: GIRAPH-80 Refactor vertices to not expose the internal datastructure for holding messages

2011-12-17 Thread Sebastian Schelter
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3203/ --- (Updated 2011-12-17 09:36:06.229668) Review request for giraph. Summary

[jira] [Updated] (GIRAPH-105) BspServiceMaster.checkWorkers() should return empty lists instead of null

2011-12-17 Thread Sebastian Schelter (Updated) (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-105?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sebastian Schelter updated GIRAPH-105: -- Attachment: GIRAPH-105.patch BspServiceMaster.checkWorkers() should return empty

Re: Running tests in pseudo-distributed mode

2011-12-17 Thread Avery Ching
We should document this somewhere. It is not intuitive as you mention. Avery On 12/17/11 1:41 AM, Sebastian Schelter wrote: A small hint for everyone who wants to run giraph's unit tests on a pseudo-distributed single node hadoop cluster: You have to adjust the configuration to allow 4

Re: Running tests in pseudo-distributed mode

2011-12-17 Thread Sebastian Schelter
Wrote a blogpost about it :) Maybe it can be copied to giraph's wiki? http://ssc.io/running-giraphs-unit-tests-in-pseudo-distributed-mode/ --sebastian On 17.12.2011 18:38, Avery Ching wrote: We should document this somewhere. It is not intuitive as you mention. Avery On 12/17/11 1:41

Re: Running tests in pseudo-distributed mode

2011-12-17 Thread Claudio Martella
nice contribution, thanks! maybe you can write a small patch to the giraph documentation to add the content (and a link to your post, for your PR ;) )? On Sat, Dec 17, 2011 at 6:48 PM, Sebastian Schelter s...@apache.org wrote: Wrote a blogpost about it :) Maybe it can be copied to giraph's wiki?

Re: Review Request: GIRAPH-80 Refactor vertices to not expose the internal datastructure for holding messages

2011-12-17 Thread Avery Ching
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3203/#review3967 --- Ship it! +1. Thanks for the changes. I will commit and then open

[jira] [Commented] (GIRAPH-80) Don't expose the list holding the messages in BasicVertex

2011-12-17 Thread jirapos...@reviews.apache.org (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-80?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13171788#comment-13171788 ] jirapos...@reviews.apache.org commented on GIRAPH-80: -

[jira] [Created] (GIRAPH-106) Refactor prepareSuperstep() to make setMessages(IterableM messages) package-private

2011-12-17 Thread Avery Ching (Created) (JIRA)
Refactor prepareSuperstep() to make setMessages(IterableM messages) package-private - Key: GIRAPH-106 URL: https://issues.apache.org/jira/browse/GIRAPH-106 Project: