Re: Review Request: Make EdgeListVertex the default vertex implementation, fix bugs related to EdgeListVertex.

2012-01-02 Thread Sebastian Schelter
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3349/#review4168 --- Had a quick look over your changes and everything looked good. I think

[jira] [Commented] (GIRAPH-116) Make EdgeListVertex the default vertex implementation, fix bugs related to EdgeListVertex.

2012-01-02 Thread jirapos...@reviews.apache.org (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13178348#comment-13178348 ] jirapos...@reviews.apache.org commented on GIRAPH-116: --

Persisting global values

2012-01-02 Thread Sebastian Schelter
Hi, I'm working on an algorithm that computes a global value of the graph (its so called effective diameter) and I have an Aggregator with which this value can be computed. What would be the correct place to implement this computation? I thought about WorkerContext first, but it seems that this i

[jira] [Created] (GIRAPH-117) DefaultWorkerContext should preserve the method signatures of WorkerContext

2012-01-02 Thread Sebastian Schelter (Created) (JIRA)
DefaultWorkerContext should preserve the method signatures of WorkerContext --- Key: GIRAPH-117 URL: https://issues.apache.org/jira/browse/GIRAPH-117 Project: Giraph Iss

[jira] [Updated] (GIRAPH-117) DefaultWorkerContext should preserve the method signatures of WorkerContext

2012-01-02 Thread Sebastian Schelter (Updated) (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-117?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sebastian Schelter updated GIRAPH-117: -- Attachment: GIRAPH-117.patch > DefaultWorkerContext should preserve the method sign

Re: Review Request: Make EdgeListVertex the default vertex implementation, fix bugs related to EdgeListVertex.

2012-01-02 Thread Avery Ching
> On 2012-01-02 11:04:25, Sebastian Schelter wrote: > > Had a quick look over your changes and everything looked good. I think it's > > right to assume that most implementations will use static graphs and to > > offer EdgeListVertex as the default extension point for this. The only > > thing I

[jira] [Commented] (GIRAPH-116) Make EdgeListVertex the default vertex implementation, fix bugs related to EdgeListVertex.

2012-01-02 Thread jirapos...@reviews.apache.org (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13178498#comment-13178498 ] jirapos...@reviews.apache.org commented on GIRAPH-116: -- bq. On 201

Re: Review Request: Make EdgeListVertex the default vertex implementation, fix bugs related to EdgeListVertex.

2012-01-02 Thread Sebastian Schelter
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3349/#review4170 --- Ship it! Ok, I understood this wrong. I'm fine with the changes then.

[jira] [Commented] (GIRAPH-116) Make EdgeListVertex the default vertex implementation, fix bugs related to EdgeListVertex.

2012-01-02 Thread jirapos...@reviews.apache.org (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13178501#comment-13178501 ] jirapos...@reviews.apache.org commented on GIRAPH-116: --

Re: Review Request: Make EdgeListVertex the default vertex implementation, fix bugs related to EdgeListVertex.

2012-01-02 Thread Avery Ching
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3349/ --- (Updated 2012-01-02 18:51:05.007864) Review request for giraph. Changes --

[jira] [Commented] (GIRAPH-116) Make EdgeListVertex the default vertex implementation, fix bugs related to EdgeListVertex.

2012-01-02 Thread jirapos...@reviews.apache.org (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13178506#comment-13178506 ] jirapos...@reviews.apache.org commented on GIRAPH-116: --

[jira] [Commented] (GIRAPH-117) DefaultWorkerContext should preserve the method signatures of WorkerContext

2012-01-02 Thread Avery Ching (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13178510#comment-13178510 ] Avery Ching commented on GIRAPH-117: +1, looks fine to me. > DefaultW

[jira] [Commented] (GIRAPH-116) Make EdgeListVertex the default vertex implementation, fix bugs related to EdgeListVertex.

2012-01-02 Thread Hudson (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13178514#comment-13178514 ] Hudson commented on GIRAPH-116: --- Integrated in Giraph-trunk-Commit #60 (See [https://builds

[jira] [Resolved] (GIRAPH-116) Make EdgeListVertex the default vertex implementation, fix bugs related to EdgeListVertex.

2012-01-02 Thread Avery Ching (Resolved) (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-116?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Avery Ching resolved GIRAPH-116. Resolution: Fixed Thanks for the fast review Sebastian. Hopefully new folks will be less irritate

Re: Persisting global values

2012-01-02 Thread Avery Ching
There is support that Claudio added for exporting aggregator values (https://issues.apache.org/jira/browse/GIRAPH-10). You could probably also do your final computation there if that is what you want (if you want to do end of application manipulation). WorkerContext would be a good way to do

[jira] [Commented] (GIRAPH-93) Hive input / output format

2012-01-02 Thread Dmitriy V. Ryaboy (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-93?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13178607#comment-13178607 ] Dmitriy V. Ryaboy commented on GIRAPH-93: - I suppose one could fake this by adding

[jira] [Commented] (GIRAPH-93) Hive input / output format

2012-01-02 Thread Avery Ching (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-93?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13178616#comment-13178616 ] Avery Ching commented on GIRAPH-93: --- Interesting idea. Maybe I'll look around for an exa