[jira] [Commented] (GIRAPH-83) Is Vertex correct yet?

2011-11-17 Thread Jake Mannix (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-83?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13152373#comment-13152373 ] Jake Mannix commented on GIRAPH-83: --- bq. In that Vertex is responsible for maintaining

[jira] [Commented] (GIRAPH-78) Be smarter about multiple instances of the same vertex

2011-11-16 Thread Jake Mannix (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-78?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13151873#comment-13151873 ] Jake Mannix commented on GIRAPH-78: --- Yeah, that's what I've been thinking too: each

[jira] [Commented] (GIRAPH-83) Is Vertex correct yet?

2011-11-15 Thread Jake Mannix (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-83?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13150680#comment-13150680 ] Jake Mannix commented on GIRAPH-83: --- I agree that simplifying this class is a good idea.

[jira] [Commented] (GIRAPH-45) Improve the way to keep outgoing messages

2011-11-15 Thread Jake Mannix (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-45?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13150784#comment-13150784 ] Jake Mannix commented on GIRAPH-45: --- @Jakob My comment about avoiding disk *and* having

[jira] [Commented] (GIRAPH-80) Don't expose the list holding the messages in BasicVertex

2011-11-14 Thread Jake Mannix (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-80?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13149887#comment-13149887 ] Jake Mannix commented on GIRAPH-80: --- Can we change both addMessages() and getMessages()

[jira] [Commented] (GIRAPH-74) GIRAPH-36 missed a couple of liners when passing from Vertex to BasicVertex

2011-11-10 Thread Jake Mannix (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-74?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13147948#comment-13147948 ] Jake Mannix commented on GIRAPH-74: --- In general, I'd prefer setHalted(boolean), but this

[jira] [Commented] (GIRAPH-11) Improve the graph distribution of Giraph

2011-11-09 Thread Jake Mannix (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-11?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13147194#comment-13147194 ] Jake Mannix commented on GIRAPH-11: --- wow, there's a monster diff! I'm glad I don't have

[jira] [Commented] (GIRAPH-64) Create VertexRunner to make it easier to run users' computations

2011-11-03 Thread Jake Mannix (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-64?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13143231#comment-13143231 ] Jake Mannix commented on GIRAPH-64: --- Hey Jakob, I put some comments in rb, but looks like

[jira] [Commented] (GIRAPH-36) Ensure that subclassing BasicVertex is possible by user apps

2011-11-02 Thread Jake Mannix (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-36?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13141994#comment-13141994 ] Jake Mannix commented on GIRAPH-36: --- Excellent, looks good to me. +1 for committing we

[jira] [Commented] (GIRAPH-71) SequenceFileVertexInputFormat missing license header; rat fails

2011-11-02 Thread Jake Mannix (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-71?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13142569#comment-13142569 ] Jake Mannix commented on GIRAPH-71: --- +1 from me, not sure why it passed for me, I was

[jira] [Commented] (GIRAPH-64) Create VertexRunner to make it easier to run users' computations

2011-11-02 Thread Jake Mannix (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-64?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13142593#comment-13142593 ] Jake Mannix commented on GIRAPH-64: --- I'd be happy to review this too (I wrote the

[jira] [Commented] (GIRAPH-36) Ensure that subclassing BasicVertex is possible by user apps

2011-11-01 Thread Jake Mannix (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-36?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13141338#comment-13141338 ] Jake Mannix commented on GIRAPH-36: --- Hmmm... removing access to GraphState in userland

[jira] [Commented] (GIRAPH-36) Ensure that subclassing BasicVertex is possible by user apps

2011-10-31 Thread Jake Mannix (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-36?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13139978#comment-13139978 ] Jake Mannix commented on GIRAPH-36: --- Yeah, sorry it's so bit, Hyunsik - GIRAPH-28 kinda

[jira] [Commented] (GIRAPH-36) Ensure that subclassing BasicVertex is possible by user apps

2011-10-31 Thread Jake Mannix (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-36?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13140330#comment-13140330 ] Jake Mannix commented on GIRAPH-36: --- 1) BspUtils.createVertex(Configuration conf,