[jira] [Commented] (GIRAPH-36) Ensure that subclassing BasicVertex is possible by user apps

2011-11-02 Thread Avery Ching (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-36?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13141965#comment-13141965 ] Avery Ching commented on GIRAPH-36: --- +1. Jake, just re-ran with your new patch. Passed

[jira] [Commented] (GIRAPH-36) Ensure that subclassing BasicVertex is possible by user apps

2011-11-02 Thread Jake Mannix (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-36?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13141994#comment-13141994 ] Jake Mannix commented on GIRAPH-36: --- Excellent, looks good to me. +1 for committing we

Re: [jira] [Commented] (GIRAPH-36) Ensure that subclassing BasicVertex is possible by user apps

2011-11-02 Thread Claudio Martella
Great, so I can I base GIRAPH-10 and GIRAPH-47 after this one! About my use case: I'm implementing a batch path query engine where the queries are XPath-like queries. Each query is a stack of conditions, each element assigned to a depth of the path traversal. A message is a stack. Not each

[jira] [Commented] (GIRAPH-36) Ensure that subclassing BasicVertex is possible by user apps

2011-11-02 Thread Jakob Homan (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-36?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13142573#comment-13142573 ] Jakob Homan commented on GIRAPH-36: --- Great work, Jake. One thing I notice while reading

[jira] [Commented] (GIRAPH-36) Ensure that subclassing BasicVertex is possible by user apps

2011-11-02 Thread Claudio Martella (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-36?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13142581#comment-13142581 ] Claudio Martella commented on GIRAPH-36: Hi Jakob, as a matter of fact, I believe,

[jira] [Commented] (GIRAPH-36) Ensure that subclassing BasicVertex is possible by user apps

2011-11-02 Thread Jakob Homan (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-36?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13142615#comment-13142615 ] Jakob Homan commented on GIRAPH-36: --- bq. Can GIRAPH-47 be a start for what you have in

[jira] [Commented] (GIRAPH-36) Ensure that subclassing BasicVertex is possible by user apps

2011-11-01 Thread Avery Ching (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-36?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13140974#comment-13140974 ] Avery Ching commented on GIRAPH-36: --- Regarding 1) I think it would be safer for use to

[jira] [Commented] (GIRAPH-36) Ensure that subclassing BasicVertex is possible by user apps

2011-11-01 Thread Jake Mannix (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-36?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13141338#comment-13141338 ] Jake Mannix commented on GIRAPH-36: --- Hmmm... removing access to GraphState in userland

[jira] [Commented] (GIRAPH-36) Ensure that subclassing BasicVertex is possible by user apps

2011-11-01 Thread Avery Ching (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-36?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13141573#comment-13141573 ] Avery Ching commented on GIRAPH-36: --- Since this is a somewhat large change, can you also

[jira] [Commented] (GIRAPH-36) Ensure that subclassing BasicVertex is possible by user apps

2011-10-31 Thread Hyunsik Choi (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-36?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13139976#comment-13139976 ] Hyunsik Choi commented on GIRAPH-36: Looks great! Actually, I need more time to fully

[jira] [Commented] (GIRAPH-36) Ensure that subclassing BasicVertex is possible by user apps

2011-10-31 Thread Jake Mannix (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-36?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13139978#comment-13139978 ] Jake Mannix commented on GIRAPH-36: --- Yeah, sorry it's so bit, Hyunsik - GIRAPH-28 kinda

Re: [jira] [Commented] (GIRAPH-36) Ensure that subclassing BasicVertex is possible by user apps

2011-10-31 Thread Claudio Martella
patch looks very nice from italy as well :) I'll test it this week on my setup. On Mon, Oct 31, 2011 at 8:26 AM, Jake Mannix (Commented) (JIRA) j...@apache.org wrote:    [

[jira] [Commented] (GIRAPH-36) Ensure that subclassing BasicVertex is possible by user apps

2011-10-31 Thread Avery Ching (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-36?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13140279#comment-13140279 ] Avery Ching commented on GIRAPH-36: --- Jake, Your suggestion on 1) will work, but couldn't

[jira] [Commented] (GIRAPH-36) Ensure that subclassing BasicVertex is possible by user apps

2011-10-31 Thread Jake Mannix (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-36?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13140330#comment-13140330 ] Jake Mannix commented on GIRAPH-36: --- 1) BspUtils.createVertex(Configuration conf,

Re: [jira] [Commented] (GIRAPH-36) Ensure that subclassing BasicVertex is possible by user apps

2011-10-31 Thread Claudio Martella
I actually like the idea of having the messages being inserted at vertex load. Currently I'm actually fighting with this functionality missing and was going to open and issue sooner or later. On Mon, Oct 31, 2011 at 6:19 PM, Jake Mannix (Commented) (JIRA) j...@apache.org wrote:    [

Re: [jira] [Commented] (GIRAPH-36) Ensure that subclassing BasicVertex is possible by user apps

2011-10-31 Thread Avery Ching
I'd also like to hear the use case. Currently we don't dump messages in the vertex output format, but maybe there is a similar case to do so? Avery On 10/31/11 11:46 AM, Jake Mannix wrote: Well I guess that gives us one reason to keep it in the API. What's the reasoning? Are there static

[jira] [Commented] (GIRAPH-36) Ensure that subclassing BasicVertex is possible by user apps

2011-10-30 Thread Avery Ching (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-36?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13139871#comment-13139871 ] Avery Ching commented on GIRAPH-36: --- Tried out your stuff Jake. Unittests passed for me.

[jira] [Commented] (GIRAPH-36) Ensure that subclassing BasicVertex is possible by user apps

2011-10-13 Thread Claudio Martella (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-36?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13126432#comment-13126432 ] Claudio Martella commented on GIRAPH-36: Hey Jake, did you get any chance to fix

[jira] [Commented] (GIRAPH-36) Ensure that subclassing BasicVertex is possible by user apps

2011-09-17 Thread Jake Mannix (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-36?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13107281#comment-13107281 ] Jake Mannix commented on GIRAPH-36: --- Initial thoughts: VertexReader defines a

[jira] [Commented] (GIRAPH-36) Ensure that subclassing BasicVertex is possible by user apps

2011-09-17 Thread Jake Mannix (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-36?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13107282#comment-13107282 ] Jake Mannix commented on GIRAPH-36: --- In fact, thinking about VertexReader further, it

[jira] [Commented] (GIRAPH-36) Ensure that subclassing BasicVertex is possible by user apps

2011-09-17 Thread Avery Ching (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-36?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13107286#comment-13107286 ] Avery Ching commented on GIRAPH-36: --- The reason for the current VertexReader API was to

[jira] [Commented] (GIRAPH-36) Ensure that subclassing BasicVertex is possible by user apps

2011-09-17 Thread Avery Ching (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-36?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13107350#comment-13107350 ] Avery Ching commented on GIRAPH-36: --- There is an out-of-core part as well though