xartigas pushed a commit to branch master.
http://git.enlightenment.org/core/efl.git/commit/?id=090df4331b9c680d50b884ccac8f39c0f312fc16
commit 090df4331b9c680d50b884ccac8f39c0f312fc16
Author: Jaehyun Cho <jae_hyun....@samsung.com>
Date: Wed Jan 15 14:35:03 2020 +0100
evas_gesture: change getter methods to read-only properties
Summary:
From language bindings' perspective, it seems better that read-only
properties are provided instead of getter methods.
ref T8557
Reviewers: segfaultxavi, CHAN
Reviewed By: segfaultxavi
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T8557
Differential Revision: https://phab.enlightenment.org/D11094
---
src/lib/evas/gesture/efl_canvas_gesture_flick.c | 4 ++--
src/lib/evas/gesture/efl_canvas_gesture_flick.eo | 20 ++++++++++++++------
src/lib/evas/gesture/efl_canvas_gesture_momentum.c | 2 +-
src/lib/evas/gesture/efl_canvas_gesture_momentum.eo | 10 +++++++---
src/lib/evas/gesture/efl_canvas_gesture_zoom.c | 4 ++--
src/lib/evas/gesture/efl_canvas_gesture_zoom.eo | 20 ++++++++++++++------
6 files changed, 40 insertions(+), 20 deletions(-)
diff --git a/src/lib/evas/gesture/efl_canvas_gesture_flick.c
b/src/lib/evas/gesture/efl_canvas_gesture_flick.c
index 1095a84652..faa8e3812f 100644
--- a/src/lib/evas/gesture/efl_canvas_gesture_flick.c
+++ b/src/lib/evas/gesture/efl_canvas_gesture_flick.c
@@ -16,13 +16,13 @@ _efl_canvas_gesture_flick_efl_object_constructor(Eo *obj,
Efl_Canvas_Gesture_Fli
}
EOLIAN static Eina_Vector2
-_efl_canvas_gesture_flick_momentum_get(Eo *obj EINA_UNUSED,
Efl_Canvas_Gesture_Flick_Data *pd)
+_efl_canvas_gesture_flick_momentum_get(const Eo *obj EINA_UNUSED,
Efl_Canvas_Gesture_Flick_Data *pd)
{
return pd->momentum;
}
EOLIAN static double
-_efl_canvas_gesture_flick_angle_get(Eo *obj EINA_UNUSED,
Efl_Canvas_Gesture_Flick_Data *pd)
+_efl_canvas_gesture_flick_angle_get(const Eo *obj EINA_UNUSED,
Efl_Canvas_Gesture_Flick_Data *pd)
{
return pd->angle;
}
diff --git a/src/lib/evas/gesture/efl_canvas_gesture_flick.eo
b/src/lib/evas/gesture/efl_canvas_gesture_flick.eo
index bec2f127c8..a624a529f9 100644
--- a/src/lib/evas/gesture/efl_canvas_gesture_flick.eo
+++ b/src/lib/evas/gesture/efl_canvas_gesture_flick.eo
@@ -10,15 +10,23 @@ class @beta Efl.Canvas.Gesture_Flick extends
Efl.Canvas.Gesture
]]
c_prefix: efl_gesture_flick;
methods {
- momentum_get {
- [[Gets flick gesture momentum value, this is, the direction in which
the
+ @property momentum {
+ [[The flick gesture momentum value, this is, the direction in which
the
pointer was flicked.]]
- return: Eina.Vector2; [[The momentum vector.]]
+ get {
+ }
+ values {
+ momentum: Eina.Vector2; [[The momentum vector.]]
+ }
}
- angle_get {
- [[Gets flick gesture direction angle, this is, the angle in which the
+ @property angle {
+ [[The flick gesture direction angle, this is, the angle in which the
pointer was flicked.]]
- return: double; [[The angle value.]]
+ get {
+ }
+ values {
+ angle: double; [[The angle value.]]
+ }
}
}
implements {
diff --git a/src/lib/evas/gesture/efl_canvas_gesture_momentum.c
b/src/lib/evas/gesture/efl_canvas_gesture_momentum.c
index e7eb34ad2b..91d2ca8f1d 100644
--- a/src/lib/evas/gesture/efl_canvas_gesture_momentum.c
+++ b/src/lib/evas/gesture/efl_canvas_gesture_momentum.c
@@ -16,7 +16,7 @@ _efl_canvas_gesture_momentum_efl_object_constructor(Eo *obj,
Efl_Canvas_Gesture_
}
EOLIAN static Eina_Vector2
-_efl_canvas_gesture_momentum_momentum_get(Eo *obj EINA_UNUSED,
Efl_Canvas_Gesture_Momentum_Data *pd)
+_efl_canvas_gesture_momentum_momentum_get(const Eo *obj EINA_UNUSED,
Efl_Canvas_Gesture_Momentum_Data *pd)
{
return pd->momentum;
}
diff --git a/src/lib/evas/gesture/efl_canvas_gesture_momentum.eo
b/src/lib/evas/gesture/efl_canvas_gesture_momentum.eo
index d3bd578e1c..715743c49b 100644
--- a/src/lib/evas/gesture/efl_canvas_gesture_momentum.eo
+++ b/src/lib/evas/gesture/efl_canvas_gesture_momentum.eo
@@ -10,9 +10,13 @@ class @beta Efl.Canvas.Gesture_Momentum extends
Efl.Canvas.Gesture
]]
c_prefix: efl_gesture_momentum;
methods {
- momentum_get {
- [[Gets the momentum value, this is, the direction in which the action
occurred.]]
- return: Eina.Vector2; [[The momentum vector.]]
+ @property momentum {
+ [[The momentum value, this is, the direction in which the action
occurred.]]
+ get {
+ }
+ values {
+ momentum: Eina.Vector2; [[The momentum vector.]]
+ }
}
}
implements {
diff --git a/src/lib/evas/gesture/efl_canvas_gesture_zoom.c
b/src/lib/evas/gesture/efl_canvas_gesture_zoom.c
index 3ac4ffcbf4..9ea7533aeb 100644
--- a/src/lib/evas/gesture/efl_canvas_gesture_zoom.c
+++ b/src/lib/evas/gesture/efl_canvas_gesture_zoom.c
@@ -21,13 +21,13 @@ _efl_canvas_gesture_zoom_efl_object_destructor(Eo *obj,
Efl_Canvas_Gesture_Zoom_
}
EOLIAN static double
-_efl_canvas_gesture_zoom_radius_get(Eo *obj EINA_UNUSED,
Efl_Canvas_Gesture_Zoom_Data *pd)
+_efl_canvas_gesture_zoom_radius_get(const Eo *obj EINA_UNUSED,
Efl_Canvas_Gesture_Zoom_Data *pd)
{
return pd->radius;
}
EOLIAN static double
-_efl_canvas_gesture_zoom_zoom_get(Eo *obj EINA_UNUSED,
Efl_Canvas_Gesture_Zoom_Data *pd)
+_efl_canvas_gesture_zoom_zoom_get(const Eo *obj EINA_UNUSED,
Efl_Canvas_Gesture_Zoom_Data *pd)
{
return pd->zoom;
}
diff --git a/src/lib/evas/gesture/efl_canvas_gesture_zoom.eo
b/src/lib/evas/gesture/efl_canvas_gesture_zoom.eo
index 1471a9401c..1663a76440 100644
--- a/src/lib/evas/gesture/efl_canvas_gesture_zoom.eo
+++ b/src/lib/evas/gesture/efl_canvas_gesture_zoom.eo
@@ -8,16 +8,24 @@ class @beta Efl.Canvas.Gesture_Zoom extends Efl.Canvas.Gesture
]]
c_prefix: efl_gesture_zoom;
methods {
- radius_get {
- [[Gets the current radius (i.e. the distance between the two fingers)
of the gesture.]]
- return: double; [[The radius value in pixels.]]
+ @property radius {
+ [[The current radius (i.e. the distance between the two fingers) of
the gesture.]]
+ get {
+ }
+ values {
+ radius: double; [[The radius value in pixels.]]
+ }
}
- zoom_get {
- [[Gets the current zoom value of the gesture. When the gesture
begins, the finger
+ @property zoom {
+ [[The current zoom value of the gesture. When the gesture begins, the
finger
distance is recorded. When the distance becomes greater than the
initial one, a
zoom value greater than $[1.0] is reported. When it becomes
smaller, a zoom value
lesser than $[1.0] is reported.]]
- return: double; [[The zoom value. $[1.0] means no zoom.]]
+ get {
+ }
+ values {
+ zoom: double; [[The zoom value. $[1.0] means no zoom.]]
+ }
}
}
implements {
--
