cedric pushed a commit to branch master. http://git.enlightenment.org/core/efl.git/commit/?id=94be8a88d3c28fd8b339b141f2f209a01e589564
commit 94be8a88d3c28fd8b339b141f2f209a01e589564 Author: Jaehyun Cho <jae_hyun....@samsung.com> Date: Wed Feb 13 07:59:46 2019 +0000 eet_dictionary: remove dead code If index value is not -1, then eet_dictionary_string_add() returns. Therefore, it does not need to check the index value after that. Reviewed-by: Cedric BAIL <cedric.b...@free.fr> Differential Revision: https://phab.enlightenment.org/D7922 --- src/lib/eet/eet_dictionary.c | 14 +++----------- 1 file changed, 3 insertions(+), 11 deletions(-) diff --git a/src/lib/eet/eet_dictionary.c b/src/lib/eet/eet_dictionary.c index 46e8cbf723..7a80463bd6 100644 --- a/src/lib/eet/eet_dictionary.c +++ b/src/lib/eet/eet_dictionary.c @@ -130,17 +130,9 @@ eet_dictionary_string_add(Eet_Dictionary *ed, current->str = str; current->len = len; - if (idx == -1) - { - current->next = ed->hash[hash]; - ed->hash[hash] = ed->count; - } - else - { - current->next = idx; - if (pidx != -1) ed->all[pidx].next = ed->count; - else ed->hash[hash] = ed->count; - } + current->next = ed->hash[hash]; + ed->hash[hash] = ed->count; + cnt = ed->count++; eina_rwlock_release(&ed->rwlock); return cnt; --