bu5hm4n pushed a commit to branch master.
http://git.enlightenment.org/core/efl.git/commit/?id=d6094b799584aa0d321c28f9115eddc3515c329a
commit d6094b799584aa0d321c28f9115eddc3515c329a
Author: Ali Alzyod <ali198...@gmail.com>
Date: Tue Jan 28 17:04:51 2020 +0000
efl.ui.textbox: replace strncmp with strcmp for Part
Reviewed-by: Marcel Hollerbach <m...@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D11218
---
src/lib/elementary/efl_ui_textbox.c | 16 ++++++++--------
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/src/lib/elementary/efl_ui_textbox.c
b/src/lib/elementary/efl_ui_textbox.c
index 420056d990..705ac1bef4 100644
--- a/src/lib/elementary/efl_ui_textbox.c
+++ b/src/lib/elementary/efl_ui_textbox.c
@@ -3283,18 +3283,18 @@ _efl_ui_textbox_item_factory_get(const Eo *obj
EINA_UNUSED, Efl_Ui_Textbox_Data
/* Efl.Part begin */
-#define STRCMP(X, Y) strncmp((X), (Y), strlen(X))
-
static Eina_Bool
_efl_ui_textbox_text_set(Eo *obj EINA_UNUSED, Efl_Ui_Textbox_Data *pd,
const char *part, const char *text)
{
- if (!STRCMP("efl.text_guide", part))
+ if (!part) return EINA_FALSE;
+
+ if (!strcmp("efl.text_guide", part))
{
efl_text_set(pd->text_guide_obj, text);
return EINA_TRUE;
}
- else if (!STRCMP("efl.text", part))
+ else if (!strcmp("efl.text", part))
{
efl_text_set(pd->text_obj, text);
return EINA_TRUE;
@@ -3307,11 +3307,13 @@ static const char *
_efl_ui_textbox_text_get(Eo *obj EINA_UNUSED, Efl_Ui_Textbox_Data *pd,
const char *part)
{
- if (!STRCMP("efl.text_guide", part))
+ if (!part) return EINA_FALSE;
+
+ if (!strcmp("efl.text_guide", part))
{
return efl_text_get(pd->text_guide_obj);
}
- else if (!STRCMP("efl.text", part))
+ else if (!strcmp("efl.text", part))
{
return efl_text_get(pd->text_obj);
}
@@ -3319,8 +3321,6 @@ _efl_ui_textbox_text_get(Eo *obj EINA_UNUSED,
Efl_Ui_Textbox_Data *pd,
return NULL;
}
-#undef STRCMP
-
static Eina_Bool
_part_is_efl_ui_textbox_part(const Eo *obj EINA_UNUSED, const char *part)
{
--
