jpeg pushed a commit to branch master.
http://git.enlightenment.org/core/efl.git/commit/?id=fc3cbaca67537bf2cf77ee7bd41ddd8c5e333c09
commit fc3cbaca67537bf2cf77ee7bd41ddd8c5e333c09
Author: Jean-Philippe Andre <jp.an...@samsung.com>
Date: Wed Nov 18 11:17:27 2015 +0900
Edje: Fix Evas 3D eet data descriptors
Memleak found with valgrind points to this line, where clearly the
edd field name is incorrect. It looks like this feature has no example,
no test case either.
This breaks EDJ ABI!
I do this because I believe there are zero users of this API
at this point, as Evas 3D is still not ready yet.
See also https://phab.enlightenment.org/D2544
@fix
---
src/lib/edje/edje_data.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/src/lib/edje/edje_data.c b/src/lib/edje/edje_data.c
index f499181..218a416 100644
--- a/src/lib/edje/edje_data.c
+++ b/src/lib/edje/edje_data.c
@@ -853,9 +853,9 @@ _edje_edd_init(void)
#define EET_DATA_DESCRIPTOR_ADD_SUB_NESTED_LOOK(Edd, Type, Dec)
\
{
\
- EET_DATA_DESCRIPTOR_ADD_BASIC_ARRAY(Edd, Type, "Dec##.orientation.look1",
Dec.orientation.data, EDJE_T_FLOAT); \
- EET_DATA_DESCRIPTOR_ADD_BASIC_ARRAY(Edd, Type, "Dec##.orientation.look2",
Dec.orientation.data, EDJE_T_FLOAT); \
- EET_DATA_DESCRIPTOR_ADD_BASIC(Edd, Type, "Dec##.orientation.look_to",
Dec.orientation.look_to, EET_T_INT); \
+ EET_DATA_DESCRIPTOR_ADD_BASIC_ARRAY(Edd, Type, #Dec ".orientation.look1",
Dec.orientation.data, EDJE_T_FLOAT); \
+ EET_DATA_DESCRIPTOR_ADD_BASIC_ARRAY(Edd, Type, #Dec ".orientation.look2",
Dec.orientation.data, EDJE_T_FLOAT); \
+ EET_DATA_DESCRIPTOR_ADD_BASIC(Edd, Type, #Dec ".orientation.look_to",
Dec.orientation.look_to, EET_T_INT); \
}
EET_EINA_FILE_DATA_DESCRIPTOR_CLASS_SET(&eddc,
Edje_Part_Description_Common);
--
