[EGIT] [core/efl] master 04/06: efl_ui_selection_manager: Fix unchecked return value

[Christopher Michael]

bu5hm4n pushed a commit to branch master.

http://git.enlightenment.org/core/efl.git/commit/?id=62d7d8a418df461f61600ff7eafc70a02d8ef2b5

commit 62d7d8a418df461f61600ff7eafc70a02d8ef2b5
Author: Christopher Michael <cp.mich...@samsung.com>
Date:   Tue Mar 12 10:11:21 2019 -0400

    efl_ui_selection_manager: Fix unchecked return value
    
    This patch fixes an issue where the return value from ecore_x_init is
    not checked. If we fail to initialize ecore_x, then we should print
    out an error and get out.
    
    Fixes Coverity CID1399092
    
    @fix
    
    Reviewed-by: Marcel Hollerbach <m...@marcel-hollerbach.de>
    Differential Revision: https://phab.enlightenment.org/D8312
---
 src/lib/elementary/efl_ui_selection_manager.c | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/src/lib/elementary/efl_ui_selection_manager.c 
b/src/lib/elementary/efl_ui_selection_manager.c
index 7b06cfc142..2c401df14b 100644
--- a/src/lib/elementary/efl_ui_selection_manager.c
+++ b/src/lib/elementary/efl_ui_selection_manager.c
@@ -5179,7 +5179,11 @@ _efl_ui_selection_manager_efl_object_constructor(Eo 
*obj, Efl_Ui_Selection_Manag
      }
    if (init_x)
      {
-        ecore_x_init(NULL);
+        if (!ecore_x_init(NULL))
+          {
+             ERR("Could not initialize Ecore_X");
+             return NULL;
+          }
      }
 #endif
 #ifdef HAVE_ELEMENTARY_WL2

--