[PATCH v2 0/6] win32: support echo for terminal-prompt

2012-12-04 Thread Erik Faye-Lund
So here's v2 of this series. For reference, you can find v1 and it's discussions here: http://mid.gmane.org/1352815288-3996-1-git-send-email-kusmab...@gmail.com The changes since the last round: * 1/6: This patch has been added. It was missing in the last round, due to stupidity on my

[PATCH v2 1/6] mingw: correct exit-code for SIGALRM's SIG_DFL

2012-12-04 Thread Erik Faye-Lund
Make sure SIG_DFL for SIGALRM exits with 128 + SIGALRM so other processes can diagnose why it exits. While we're at it, make sure we only write to stderr if it's a terminal, and change the output to match that of Linux. Signed-off-by: Erik Faye-Lund kusmab...@gmail.com --- compat/mingw.c | 7

[PATCH v2 2/6] mingw: make fgetc raise SIGINT if apropriate

2012-12-04 Thread Erik Faye-Lund
Set a control-handler to prevent the process from terminating, and simulate SIGINT so it can be handled by a signal-handler as usual. Signed-off-by: Erik Faye-Lund kusmab...@gmail.com --- compat/mingw.c | 76 ++ compat/mingw.h | 6 + 2

[PATCH v2 3/6] compat/terminal: factor out echo-disabling

2012-12-04 Thread Erik Faye-Lund
By moving the echo-disabling code to a separate function, we can implement OS-specific versions of it for non-POSIX platforms. Signed-off-by: Erik Faye-Lund kusmab...@gmail.com --- compat/terminal.c | 43 +-- 1 file changed, 25 insertions(+), 18

[PATCH v2 4/6] compat/terminal: separate input and output handles

2012-12-04 Thread Erik Faye-Lund
On Windows, the terminal cannot be opened in read-write mode, so we need distinct pairs for reading and writing. Since this works fine on other platforms as well, always open them in pairs. Signed-off-by: Erik Faye-Lund kusmab...@gmail.com --- compat/terminal.c | 29 ++---

[PATCH v2 5/6] mingw: reuse tty-version of git_terminal_prompt

2012-12-04 Thread Erik Faye-Lund
The getpass-implementation we use on Windows isn't at all ideal; it works in raw-mode (as opposed to cooked mode), and as a result does not deal correcly with deletion, arrow-keys etc. Instead, use cooked mode to read a line at the time, allowing the C run-time to process the input properly.

[PATCH v2 6/6] mingw: get rid of getpass implementation

2012-12-04 Thread Erik Faye-Lund
There's no remaining call-sites, and as pointed out in the previous commit message, it's not quite ideal. So let's just lose it. Signed-off-by: Erik Faye-Lund kusmab...@gmail.com --- compat/mingw.c | 15 --- compat/mingw.h | 2 -- 2 files changed, 17 deletions(-) diff --git

Re: [PATCH] status: respect advice.statusHints for ahead/behind advice

2012-12-04 Thread Matthieu Moy
Junio C Hamano gits...@pobox.com writes: So let's do a lot simpler patch instead. -- 8 -- From: Jeff King p...@peff.net Date: Mon, 3 Dec 2012 01:16:57 -0500 If the user has unset advice.statusHints, we already suppress the use git reset to... hints in each stanza. The new use git push to

Re: [PATCH] fsck: warn about .git in trees

2012-12-04 Thread Andreas Ericsson
On 11/30/2012 08:50 PM, Torsten Bögershausen wrote: Having a .git entry inside a tree can cause confusing results on checkout. At the top-level, you could not checkout such a tree, as it would complain about overwriting the real .git directory. In a subdirectory, you might check it out, but

[PATCH] mingw_rmdir: do not prompt for retry when non-empty

2012-12-04 Thread Erik Faye-Lund
in ab1a11be (mingw_rmdir: set errno=ENOTEMPTY when appropriate), a check was added to prevent us from retrying to delete a directory that is both in use and non-empty. However, this logic was slightly flawed; since we didn't return immediately, we end up falling out of the retry-loop, but right

Re: [ANNOUNCE] Git v1.8.1-rc0

2012-12-04 Thread Michael J Gruber
While not being a huge problem, you may or may not want to correct one commit message: * aaf5ad5 (origin/next, gitster/next) Sync with 1.8.0-rc0 |\ | * ee26a6e (tag: v1.8.1-rc0, origin/master, origin/HEAD, gitster/master) Git 1.8.1-rc0 Cheers, Michael -- To unsubscribe from this list: send the

Re: Python extension commands in git - request for policy change

2012-12-04 Thread Felipe Contreras
On Mon, Dec 3, 2012 at 3:45 PM, Philippe Vaucher philippe.vauc...@gmail.com wrote: Also, you are ignoring all the advantages that shell has and python does not. Out of curiosity, can you list the advantages? From what I gathered: - no need to install bash Unless you are in Windows or OS X.

Re: Python extension commands in git - request for policy change

2012-12-04 Thread Stephen Bash
- Original Message - From: Felipe Contreras felipe.contre...@gmail.com Sent: Tuesday, December 4, 2012 9:19:18 AM Subject: Re: Python extension commands in git - request for policy change Also, you are ignoring all the advantages that shell has and python does not. Out of

Re: Python extension commands in git - request for policy change

2012-12-04 Thread Martin Langhoff
On Sat, Nov 24, 2012 at 9:44 PM, Eric S. Raymond e...@thyrsus.com wrote: git presently contains one Python extension command, Pete Wycoff's p4 importer. If my git-weave code is merged it will acquire another. Write a really compelling tool. Don't argue languages. Make it wonderful. The git

Re: [PATCH] mingw_rmdir: do not prompt for retry when non-empty

2012-12-04 Thread Johannes Schindelin
Hi kusma, On Tue, 4 Dec 2012, Erik Faye-Lund wrote: in ab1a11be (mingw_rmdir: set errno=ENOTEMPTY when appropriate), a check was added to prevent us from retrying to delete a directory that is both in use and non-empty. However, this logic was slightly flawed; since we didn't return

Re: [msysGit] [PATCH/RFC 1/5] mingw: make fgetc raise SIGINT if apropriate

2012-12-04 Thread Johannes Schindelin
Hi kusma, On Sat, 1 Dec 2012, Erik Faye-Lund wrote: On Fri, Nov 30, 2012 at 6:58 PM, Johannes Schindelin johannes.schinde...@gmx.de wrote: Hi, On Tue, 13 Nov 2012, Erik Faye-Lund wrote: Set a control-handler to prevent the process from terminating, and simulate SIGINT so it can be

Re: [msysGit] [PATCH/RFC 2/5] compat/terminal: factor out echo-disabling

2012-12-04 Thread Johannes Schindelin
Hi kusma, On Sat, 1 Dec 2012, Erik Faye-Lund wrote: On Fri, Nov 30, 2012 at 6:59 PM, Johannes Schindelin johannes.schinde...@gmx.de wrote: Hi, On Tue, 13 Nov 2012, Erik Faye-Lund wrote: By moving the echo-disabling code to a separate function, we can implement OS-specific versions

Re: [msysGit] [PATCH/RFC 1/5] mingw: make fgetc raise SIGINT if apropriate

2012-12-04 Thread Erik Faye-Lund
On Tue, Dec 4, 2012 at 6:12 PM, Johannes Schindelin johannes.schinde...@gmx.de wrote: Hi kusma, On Sat, 1 Dec 2012, Erik Faye-Lund wrote: On Fri, Nov 30, 2012 at 6:58 PM, Johannes Schindelin johannes.schinde...@gmx.de wrote: Hi, On Tue, 13 Nov 2012, Erik Faye-Lund wrote: Set a

Re: [RFC] Add basic syntax check on shell scripts

2012-12-04 Thread Junio C Hamano
Nguyen Thai Ngoc Duy pclo...@gmail.com writes: This (once it gets cleaned up to reduce false positives) belongs to cd t make test-lint. Or a project commit hook? Surely. It is OK to have cd t make test-lint in your pre-commit hook. A few more things in addition to what Torsten's script

[PATCH v2] t9402: sed -i is not portable

2012-12-04 Thread Torsten Bögershausen
On some systems sed allows the usage of e.g. sed -i -e s/line1/line2/ afile to edit the file in place. Other systems don't allow that: one observed behaviour is that sed -i -e s/line1/line2/ afile creates a backup file called afile-e, which breaks the test. As sed -i is not part of POSIX, avoid

Re: [PATCH] gitk: read and write a repository specific configuration file

2012-12-04 Thread Lukasz Stelmach
W dniu 03.12.2012 22:15, Stefan Haller pisze: Lukasz Stelmach stl...@poczta.fm wrote: Enable gitk read and write repository specific configuration file: .git/k if the file exists. To make gitk use the local file simply create one, e.g. with the touch(1) command. I'm not sure I like this

Git problem with CIFS/SAMBA URLs

2012-12-04 Thread Nils Fenner
Hi guys, I tried to use url.insteadof to get URLs mapped correctly, starting with a double-slash (//). Unfortunately, Git doesn't recognize that and still tries to connect to the original URL. I am using Git in a productive environment. On Windows desktops, MsysGit 1.7.11 and 1.8.0. On ubuntu

Re: [PATCH v2] t9402: sed -i is not portable

2012-12-04 Thread Junio C Hamano
Torsten Bögershausen tbo...@web.de writes: On some systems sed allows the usage of e.g. sed -i -e s/line1/line2/ afile to edit the file in place. Other systems don't allow that: one observed behaviour is that sed -i -e s/line1/line2/ afile creates a backup file called afile-e, which breaks

[PATCH v2] submodule: add 'deinit' command

2012-12-04 Thread Jens Lehmann
With git submodule init the user is able to tell git he cares about one or more submodules and wants to have it populated on the next call to git submodule update. But currently there is no easy way he could tell git he does not care about a submodule anymore and wants to get rid of his local work

[PATCH v2] gitk: add a checkbox to control the visibility of tags

2012-12-04 Thread Łukasz Stelmach
Enable hiding of tags displayed in the tree as yellow labels. If a repository is used together with a system like Gerrit there may be quite a lot of tags used to control building and there may be hardly any place left for commit subjects. Signed-off-by: Łukasz Stelmach stl...@poczta.fm ---

[PATCH v2] gitk: read and write a repository specific configuration file

2012-12-04 Thread Łukasz Stelmach
Enable gitk read and write repository specific configuration file: .git/k if the file exists. To make gitk use the local file simply create one, e.g. with the touch(1) command. This is very useful if one uses different views for different repositories. Now there is no need to store all of them in

Re: [RFC/PATCH 1/2] reset: learn to reset to tree

2012-12-04 Thread Martin von Zweigbergk
On Sat, Dec 1, 2012 at 1:24 AM, Junio C Hamano gits...@pobox.com wrote: Martin von Zweigbergk martinv...@gmail.com writes: On Thu, Nov 29, 2012 at 2:00 PM, Martin von Zweigbergk martinv...@gmail.com wrote: Slightly off topic, but another difference (or somehow another aspect of the same

Re: [RFC] Add basic syntax check on shell scripts

2012-12-04 Thread Nguyen Thai Ngoc Duy
On Wed, Dec 5, 2012 at 2:39 AM, Junio C Hamano gits...@pobox.com wrote: Or a project commit hook? Surely. It is OK to have cd t make test-lint in your pre-commit hook. No, what I meant is a shared pre-commit script that all git devs are encouraged (or forced) to install so bugs are found

Re: [RFC/PATCH 1/2] reset: learn to reset to tree

2012-12-04 Thread Junio C Hamano
Martin von Zweigbergk martinv...@gmail.com writes: More importantly, when is it desirable not to delete deleted entries? When I am trying to check out contents of Documentation/ directory as of an older edition because we made mistakes updating the files in recent versions, with git checkout

Re: [RFC] Add basic syntax check on shell scripts

2012-12-04 Thread Junio C Hamano
Nguyen Thai Ngoc Duy pclo...@gmail.com writes: On Wed, Dec 5, 2012 at 2:39 AM, Junio C Hamano gits...@pobox.com wrote: Or a project commit hook? Surely. It is OK to have cd t make test-lint in your pre-commit hook. No, what I meant is a shared pre-commit script that all git devs are

cheap links of london bracelets design concept

2012-12-04 Thread fiower91
Links of London was established in 1990, the company established by a pair of background is fish type cuff button order began. A local restaurant for long-term customers make a pair of silver fish type cuff button as gifts, design attracted the famous London department store Harvey Nichols, and

Re: [RFC] Add basic syntax check on shell scripts

2012-12-04 Thread Jeff King
On Wed, Dec 05, 2012 at 12:43:30PM +0700, Nguyen Thai Ngoc Duy wrote: On Wed, Dec 5, 2012 at 2:39 AM, Junio C Hamano gits...@pobox.com wrote: Or a project commit hook? Surely. It is OK to have cd t make test-lint in your pre-commit hook. No, what I meant is a shared pre-commit

Re: [RFC] Add basic syntax check on shell scripts

2012-12-04 Thread Jeff King
On Wed, Dec 05, 2012 at 02:30:56AM -0500, Jeff King wrote: Anyway, I do think a shell portability lint would be a great addition to test-lint, but I am slightly skeptical that it will be easy to write a good one that does not have false positives. Still, there may be some low-hanging fruit. I